| Summary: | Review Request: perl-IO-Any - Read or write anything | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ruediger Landmann <rlandman> |
| Component: | Package Review | Assignee: | Ralf Corsepius <rc040203> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, rc040203 |
| Target Milestone: | --- | Flags: | rc040203:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-03-09 00:37:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Ruediger Landmann
2011-01-18 02:27:41 UTC
Everything OK, except: - The testsuite skips one of its tests: + ./Build test t/01_IO-Any.t ........... ok t/02_IO-Any_AnyEvent.t .. skipped: requires AnyEvent to run t/03_DATA.t ............. ok ... => Missing "BuildRequires: perl(AnyEvent)" - Duplicate "Requires:" # rpm -q --requires -p perl-IO-Any-0.04-1.fc15.noarch.rpm ... perl(IO::AtomicFile) perl(IO::AtomicFile) perl(IO::File) perl(IO::String) perl(IO::String) ... Please remove the explict "Requires: perl(IO::String)" and "perl(IO::AtomicFile)" CONSIDER (No blocker) - You are not exercising the distritbution tests. + ./Build test ... t/distribution.t ........ skipped: Test::Distribution not installed t/fixme.t ............... skipped: requires Test::Fixme to run t/pod-coverage.t ........ skipped: Test::Pod::Coverage 1.08 required for testing POD coverage t/pod-spell.t ........... skipped: Set the environment variable TEST_SPELLING to enable this test. t/pod.t ................. skipped: Test::Pod 1.22 required for testing POD I'd recommend to add the missing BRs to have them exercised. Thanks for the quick turnaround on the review Ralf! I'll enable these tests. However, it looks like we're not currently shipping Test::Fixme, so I'll package that up first before proceeding here. Setting NotReady on the whiteboard until then Cheers Rudi (In reply to comment #2) > I'll enable these tests. However, it looks like we're not currently shipping > Test::Fixme, so I'll package that up first before proceeding here. The distribution tests aren't required for packaging this package for Fedora (They are checking a package's consistency and not a package's functionality). I.e. from our POV, they are optional surplus. In other words, I'd approve this package with first 2 items from comment #1 fixed. (In reply to comment #3) > (In reply to comment #2) > > I'll enable these tests. However, it looks like we're not currently shipping > > Test::Fixme, so I'll package that up first before proceeding here. > The distribution tests aren't required for packaging this package for Fedora > (They are checking a package's consistency and not a package's functionality). > I.e. from our POV, they are optional surplus. > > In other words, I'd approve this package with first 2 items from comment #1 > fixed. Thanks Ralf; I've added the missing BuildRequires and cleared the redundant explicit Requires. I've also enabled a couple of the distribution tests and will work on Test::Fixme. Enabling the spelling test resulted in too many errors to allow the package to build, so I've left that disabled. + ./Build test t/01_IO-Any.t ........... ok t/02_IO-Any_AnyEvent.t .. ok t/03_DATA.t ............. ok t/distribution.t ........ ok .... $ rpm -q --requires -p RPMS/noarch/perl-IO-Any-0.04-2.fc14.noarch.rpm perl >= 1:5.010 perl(:MODULE_COMPAT_5.12.2) perl(Carp) perl(Fcntl) perl(File::Spec) perl(IO::AtomicFile) perl(IO::File) perl(IO::String) perl(Scalar::Util) perl(strict) perl(warnings) ... New spec: http://rlandmann.fedorapeople.org/packages/perl-IO-Any.spec New SRPM: http://rlandmann.fedorapeople.org/packages/perl-IO-Any-0.04-2.fc14.src.rpm New rpmlint output: $ rpmlint SPECS/perl-IO-Any.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint SRPMS/perl-IO-Any-0.04-2.fc14.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint RPMS/noarch/perl-IO-Any-0.04-2.fc14.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. New scratchbuild in Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2727809 Cheers Rudi md5sum: eb8d75819dc1b78febd487cb8d9dae12 IO-Any-0.04.tar.gz Testsuite results: ./Build test t/01_IO-Any.t ........... ok t/02_IO-Any_AnyEvent.t .. ok t/03_DATA.t ............. ok t/distribution.t ........ ok t/fixme.t ............... skipped: requires Test::Fixme to run t/pod-coverage.t ........ ok t/pod-spell.t ........... skipped: Set the environment variable TEST_SPELLING to enable this test. t/pod.t ................. ok All tests successful. Files=8, Tests=52, 1 wallclock secs ( 0.04 usr 0.01 sys + 0.50 cusr 0.09 csys = 0.64 CPU) Result: PASS => Can all be ignored. # rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. APPROVED Rudi? How about importing this package to git? Sorry Ralf -- I must have missed this along the way. Thanks for the review! New Package SCM Request ======================= Package Name: perl-File-Find Short Description: Nice wrapper for File::Find ala find(1) Owners: rlandmann Branches: f14 f15 el6 InitialCC: perl-sig Sorry Ralf -- I must have missed this along the way. Thanks for the review! New Package SCM Request ======================= Package Name: perl-IO-Any Short Description: Read or write anything Owners: rlandmann Branches: f14 f15 el6 InitialCC: perl-sig Git done (by process-git-requests). |