Bug 670377
Summary: | Review Request: perl-File-Finder - Nice wrapper for File::Find ala find(1) | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ruediger Landmann <rlandman> |
Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, ppisar, rc040203 |
Target Milestone: | --- | Flags: | ppisar:
fedora-review+
j: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-03-09 00:38:16 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ruediger Landmann
2011-01-18 04:34:46 UTC
This spec has several issues: * All of your Requires: perl(Test::...) should be BuildRequires: perl(Test::...) These are only used inside of the testsuite and are not Require:'ed by the actual perl module (i.e. the files below lib/) => Please make them BuildRequires. * File-Finder-0.53/t/04-ffr.t depends on perl(File::Find::Rule) => Please add BR: perl(File::Find::Rule). Minor issue: * The source0-URL doesn't work for me: # lftp -c get http://www.cpan.org/modules/by-module/File/File-Finder-0.53.gz get: Access failed: 404 Not Found (/modules/by-module/File/File-Finder-0.53.gz) This is a known issue with cpan's URL redirection, which seems to have problems in providing "by-modules" on mirrors. I'd recommend to use the "by author" URL instead: http://search.cpan.org/CPAN/authors/id/M/ME/MERLYN/File-Finder-0.53.tar.gz Ignorable issue: There seems to be an implicit dependency on File::Find inside of File::Finder::Steps.pm ATM, I am not sure, if this is a strict dependency or if this dependency can be treated optional. For now, this doesn't matter in practice, because perl(File::Find) is provides by the core perl package. => For now this issue can be ignored, IMO. Oops; sorry for the noob errors. Fixed now: BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(File::Find::Rule) BuildRequires: perl(Test::More) BuildRequires: perl(Test::Distribution) BuildRequires: perl(Test::Pod) BuildRequires: perl(Test::Pod::Coverage) BuildRequires: perl(Text::Glob) ... Source0: http://search.cpan.org/CPAN/authors/id/M/ME/MERLYN/File-Finder-%{version}.tar.gz New spec: http://rlandmann.fedorapeople.org/packages/perl-File-Finder.spec New SRPM: http://rlandmann.fedorapeople.org/packages/perl-File-Finder-0.53-2.fc14.src.rpm New rpmlint output: $ rpmlint SPECS/perl-File-Finder.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint SRPMS/perl-File-Finder-0.53-2.fc14.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint RPMS/noarch/perl-File-Finder-0.53-2.fc14.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. New scratchbuild in Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2727878 Cheers Rudi Source file is original. Ok. Summary verified from lib/File/Finder.pm. Ok. Description verified from lib/File/Finder.pm. Ok. License verified from lib/File/Finder.pm. Ok. No XS or other C binding. noarch architecture is Ok. TODO: BuildRequire perl(Exporter) (lib/File/Finder.pm:7) as it can dual-live in the future (http://search.cpan.org/~ferreira/Exporter/). All tests pass. Ok. $ rpmlint perl-File-Finder.spec ../SRPMS/perl-File-Finder-0.53-2.fc14.src.rpm ../RPMS/noarch/perl-File-Finder-0.53-2.fc14.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-File-Finder-0.53-2.fc14.noarch.rpm drwxr-xr-x 2 root root 0 bře 2 17:23 /usr/share/doc/perl-File-Finder-0.53 -rw-r--r-- 1 root root 1076 dub 8 2005 /usr/share/doc/perl-File-Finder-0.53/Changes -rw-r--r-- 1 root root 1076 pro 17 2003 /usr/share/doc/perl-File-Finder-0.53/README -rw-r--r-- 1 root root 748 dub 8 2005 /usr/share/doc/perl-File-Finder-0.53/TODO -rw-r--r-- 1 root root 4783 bře 2 17:23 /usr/share/man/man3/File::Finder.3pm.gz -rw-r--r-- 1 root root 6393 bře 2 17:23 /usr/share/man/man3/File::Finder::Steps.3pm.gz drwxr-xr-x 2 root root 0 bře 2 17:23 /usr/share/perl5/File drwxr-xr-x 2 root root 0 bře 2 17:23 /usr/share/perl5/File/Finder -rw-r--r-- 1 root root 10859 dub 8 2005 /usr/share/perl5/File/Finder.pm -rw-r--r-- 1 root root 17757 dub 8 2005 /usr/share/perl5/File/Finder/Steps.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-File-Finder-0.53-2.fc14.noarch.rpm | sort | uniq -c 1 perl(base) 1 perl(Carp) 1 perl(:MODULE_COMPAT_5.12.3) 1 perl(strict) 1 perl(Text::Glob) 1 perl(warnings) 1 perl >= 0:5.006 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rpmlib(VersionedDependencies) <= 3.0.3-1 $ rpm -q --provides -p ../RPMS/noarch/perl-File-Finder-0.53-2.fc14.noarch.rpm | sort | uniq -c 1 perl(File::Finder::Steps) = 0.53 1 perl(File::Finder) = 0.53 1 perl-File-Finder = 0.53-2.fc14 Binary dependencies Ok. $ resolvedeps-f16 ../RPMS/noarch/perl-File-Finder-0.53-2.fc14.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F16 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2878749). Ok. Otherwise package is in line with Fedora and perl packaging guidelines. Please consider fixing all `TODO' prefixed issues before pushing package into repository. Resolution: Package APPROVED. Thanks Petr! New Package SCM Request ======================= Package Name: perl-File-Find Short Description: Nice wrapper for File::Find ala find(1) Owners: rlandmann Branches: f14 f15 el6 InitialCC: perl-sig The requested name doesn't match the one in the ticket summary (Find vs Finder). Please correct whichever is incorrect and re-raise the fedora-cvs flag. Sorry Jason: New Package SCM Request ======================= Package Name: perl-File-Finder Short Description: Nice wrapper for File::Find ala find(1) Owners: rlandmann Branches: f14 f15 el6 InitialCC: perl-sig Git done (by process-git-requests). |