Bug 670477
| Summary: | Review Request: perl-HTTP-Server-Simple-PSGI - PSGI handler for HTTP::Server::Simple | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralf Corsepius <rc040203> |
| Component: | Package Review | Assignee: | Iain Arnell <iarnell> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, iarnell, jose.p.oliveira.oss, notting |
| Target Milestone: | --- | Flags: | iarnell:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-HTTP-Server-Simple-PSGI-0.14-2.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-03-21 03:32:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 665096 | ||
|
Description
Ralf Corsepius
2011-01-18 12:34:57 UTC
+ source files match upstream.
c26795112c9f616dbd37ece1c5895b55 HTTP-Server-Simple-PSGI-0.14.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
GPL+ or Artistic
+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
http://koji.fedoraproject.org/koji/taskinfo?taskID=2906114
+ package installs properly.
+ rpmlint has no complaints:
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ final provides and requires are sane:
perl(HTTP::Server::Simple::PSGI) = 0.14
perl-HTTP-Server-Simple-PSGI = 0.14-1.fc16
perl(HTTP::Server::Simple::PSGI::Writer)
=
perl >= 0:5.005_03
perl(base)
perl(HTTP::Server::Simple::CGI)
perl(:MODULE_COMPAT_5.12.3)
perl(strict)
perl(vars)
+ %check is present and all tests pass.
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/00_compile.t .. ok
All tests successful.
Files=1, Tests=1, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.03 cusr 0.00 csys = 0.04 CPU)
Result: PASS
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
APPROVED.
Thanks for the review, Iain. New Package SCM Request ======================= Package Name: perl-HTTP-Server-Simple-PSGI Short Description: PSGI handler for HTTP::Server::Simple Owners: corsepiu Branches: f13 f14 f15 InitialCC: perl-sig Git done (by process-git-requests). perl-HTTP-Server-Simple-PSGI-0.14-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-HTTP-Server-Simple-PSGI-0.14-2.fc14 perl-HTTP-Server-Simple-PSGI-0.14-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/perl-HTTP-Server-Simple-PSGI-0.14-2.fc13 perl-HTTP-Server-Simple-PSGI-0.14-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-HTTP-Server-Simple-PSGI-0.14-2.fc15 perl-HTTP-Server-Simple-PSGI-0.14-2.fc15 has been pushed to the Fedora 15 testing repository. perl-HTTP-Server-Simple-PSGI-0.14-2.fc15 has been pushed to the Fedora 15 stable repository. perl-HTTP-Server-Simple-PSGI-0.14-2.fc14 has been pushed to the Fedora 14 stable repository. perl-HTTP-Server-Simple-PSGI-0.14-2.fc13 has been pushed to the Fedora 13 stable repository. Package Change Request ====================== Package Name: perl-HTTP-Server-Simple-PSGI New Branches: el6 Owners: jpo InitialCC: perl-sig [perl-Dancer requirement chain - see bug 729504] Git done (by process-git-requests). |