| Summary: | PATCH: audacious trips over m3u files with url which contains square brackets or spaces | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> | ||||
| Component: | audacious-plugins | Assignee: | Michael Schwendt <bugs.michael> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 14 | CC: | atkac, bugs.michael | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-01-10 10:31:40 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
|
Description
Hans de Goede
2011-01-19 21:17:03 UTC
Created attachment 474360 [details] PATCH: clean urls before passing them to neon Oops, fat fingered on enter before entering a description. I noticed that audacious does not work with .m3u playlists server by: http://www.dogmazic.net/music The problem is that the http urls in their .m3u playlists contain '[' and ']' chars, which are not valid for an url, so get rejected by neon. Note that these playlists work fine in mplayer / totem. An other example of the same problem is: http://boards.audacious-media-player.org/viewtopic.php?f=1&t=249&start=0 The attached patch fixes playing these kind of playlists by urlencoding non reserved chars in an url when they need encoding. Can you please add this patch to the Fedora packages? I'm also working on getting it upstream. For a patch like this, I'd first like to hear what upstream will say about it. I've seen the mail already, but it might be an idea to open a ticket at: http://jira.atheme.org/ Further, for F14 the update to Audacious 2.4.3 takes precedence. Once it's published, it will be easier to update because a koji buildroot override will not be needed anymore: https://admin.fedoraproject.org/updates/audacious-2.4.3-1.fc14,audacious-plugins-2.4.3-1.fc14.pl1,xmp-3.3.0-2.fc14.1 Hi, Upstream reluctantly agrees that cleaning up of urls is needed in principle, but would like to see this implemented in neon rather then in audacious. I mailed with upstream neon, and got a clear no to adding this to the existing neon parse_url function. Upstream neon is willing to think about a separate cleanup url function living inside neon, but that will not help us in the short run. I'll forward you the mails since you've been dropped from the CC, and CC you again on any further discussion. Regards, Hans Sorry, it isn't important enough to think about a short term work-around. Certainly not inside Fedora's Audacious packages, if neon doesn't apply a work-around in the short term either and if Audacious' devs don't like the change so far. It's a bit like forcing a patch down Audacious' throat. https://fedoraproject.org/wiki/Staying_close_to_upstream_projects |