| Summary: | Review Request: rubygem-pr_geohash - GeoHash encode/decode library for pure Ruby | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vít Ondruch <vondruch> |
| Component: | Package Review | Assignee: | Michal Fojtik <mfojtik> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mfojtik, notting |
| Target Milestone: | --- | Flags: | mfojtik:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-02-04 11:01:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Vít Ondruch
2011-01-20 10:09:01 UTC
Taking this package for an review. Some notes:
> Requires: rubygems >= 0
> Requires: ruby >= 0
> BuildRequires: rubygems >= 0
> BuildRequires: ruby >= 0
'>= 0' is not necessary here, you can safely omit that
Formal review:
Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification.
OK
The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version
OK
The package must have a Requires and a BuildRequires on rubygems
OK
The package must provide rubygem(%{gemname}) where gemname is the name from the Gem's specification.
OK
For every dependency on a Gem named gemdep, the package must contain a Requires on rubygem(%{gemdep}) with the same version constraints as the Gem
OK
The %prep and %build sections of the specfile should be empty.
OK
The Gem must be installed into %{gemdir} defined as
%global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)
OK
The package must own the following files and directories:
%{gemdir}/gems/%{gemname}-%{version}/
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec
OK
Architecture-specific content must not be installed into %{gemdir}
OK (there is no architecture content)
If the Gem only contains pure Ruby code, it must be marked as BuildArch: noarch.
OK
All other things looks good to me, so REVIEW+. Please fix that version markers before you import this package to GIT.
Thank you for your review. New Package SCM Request ======================= Package Name: rubygem-pr_geohash Short Description: GeoHash encode/decode library for pure Ruby Owners: vondruch Branches: InitialCC: Git done (by process-git-requests). |