Bug 671185

Summary:	Editing a feature on default-group results in "nothing changed" message on activation attempt
Product:	Red Hat Enterprise MRG	Reporter:	Robert Rati <rrati>
Component:	wallaby	Assignee:	Will Benton <willb>
Status:	CLOSED ERRATA	QA Contact:	Lubos Trilety <ltrilety>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	1.3	CC:	iboverma, ltrilety, matt
Target Milestone:	1.3.2	Keywords:	FutureFeature
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	wallaby-0.10.4-1	Doc Type:	Enhancement
Doc Text:	The wallaby service calculates the scope of configuration changes on activation by examining a list of modified configuration entities. Although changes to the properties of a feature installed on the default group marked that feature as modified, the default group was not marked modified. As a consequence, making changes to features installed on the default group may not have resulted in configuration activation. With this update, the default group is correctly marked as modified whenever features installed on it are modified, with the result that activations proceed as expected.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-02-15 12:15:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Robert Rati 2011-01-20 17:30:01 UTC

Description of problem:
Adding a param to a group that is configured on the default-group should let me activate, as all nodes have a configuration change now.  However, the activation attempt fails with:

No node configurations have changed since the last activated config; activate request will have no effect.


Version-Release number of selected component (if applicable):
wallaby-0.10.0-2

How reproducible:
100%

Steps to Reproduce:
1. condor_configure_pool --default-group -a -f Master,NodeAccess
2. condor_configure_pool --activate
3. condor_configure_store -e -f Master
4. Add a new param:value to Master feature
5. condor_configure_pool --activate
  
Actual results:
Failure

Expected results:
Success

Additional info:

Comment 1 Will Benton 2011-01-21 04:58:26 UTC

Fixed in master; packaged tomorrow AM.

Comment 4 Lubos Trilety 2011-01-26 12:27:38 UTC

Successfully reproduced on:
wallaby-0.10.0-2

Comment 5 Will Benton 2011-01-27 15:50:58 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
C:  The wallaby service uses a list of modified (or "dirty") configuration entities to calculate the scope of configuration changes on an activation.  In the past, changes to the properties of a feature installed on the default group would mark that feature as modified, but not mark the default group as modified.  (This problem did not exist for features on other groups, or for modifying the set of features enabled on the default group.)
C:  As a consequence, changes to features that are installed on the default group may not result in configuration activation.
F:  Modifying features installed on the default group will now mark the default group as modified.
R:  Activations should proceed as expected after modifying features installed on the default group.

Comment 8 Lubos Trilety 2011-02-01 16:57:57 UTC

Tested with (version):
wallaby-0.10.4-2

Tested on:
RHEL5 i386,x86_64  - passed

>>> VERIFIED

Comment 9 Douglas Silas 2011-02-08 17:13:38 UTC

    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,4 +1 @@
-C:  The wallaby service uses a list of modified (or "dirty") configuration entities to calculate the scope of configuration changes on an activation.  In the past, changes to the properties of a feature installed on the default group would mark that feature as modified, but not mark the default group as modified.  (This problem did not exist for features on other groups, or for modifying the set of features enabled on the default group.)
+The wallaby service calculates the scope of configuration changes on activation by examining a list of modified configuration entities. Although changes to the properties of a feature installed on the default group marked that feature as modified, the default group was not marked modified. As a consequence, making changes to features installed on the default group may not have resulted in configuration activation. With this update, the default group is correctly marked as modified whenever features installed on it are modified, with the result that activations proceed as expected.-C:  As a consequence, changes to features that are installed on the default group may not result in configuration activation.
-F:  Modifying features installed on the default group will now mark the default group as modified.
-R:  Activations should proceed as expected after modifying features installed on the default group.

Comment 10 errata-xmlrpc 2011-02-15 12:15:23 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0217.html