Bug 671503
| Summary: | /sbin/new-memtest-pkg, line 116 refers to /sbin/nash which doesn't exist in any available package | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andre Robatino <robatino> | ||||
| Component: | memtest86+ | Assignee: | Jaroslav Škarvada <jskarvad> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 15 | CC: | bernie+fedora, jskarvad | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | memtest86+-4.10-4.fc13 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-03-31 20:03:19 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Andre Robatino
2011-01-21 17:05:12 UTC
Actually, "yum install /sbin/nash" tells me there is no package available that provides this, so this reference needs to be removed. Thanks for report. The new-memtest-pkg is RH contrib script. Previously the nash was provided by mkinitrd which was replaced by dracut. The nash is now deprecated and nothing should use it, so the new-memtest-pkg needs updating. Created attachment 479943 [details]
Proposed patch
Seems that the functionality can be substituted by findfs and it also simplifies the code.
memtest86+-4.10-5.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/memtest86+-4.10-5.fc15 Thanks - please fix for F14 and F13 as well. Also, for testing purposes, what functionality does this provide? Whatever nash was supposed to do, I never noticed it was missing. (I could probably figure it out myself, but for testers generally, it would help to have a short explanation here.) (In reply to comment #6) > Also, for testing purposes, what functionality does this provide? I don't know the full history, but it seems that the new-memtest-pkg was forked from the new-kernel-pkg some time ago. The nash was used in case you specify root device by file system LABEL in fstab. The code checks the validity of the LABEL and if it doesn't point to valid device it gets the root device from the mtab. This data is then used as the "root" kernel arg. However it is not used by the memtest86+, because it doesn't need to know where is your rootfs. Conclusion: It worked despite of the error message, because this functionality is not used by memtes86+. In case anybody used this script for other purposes than installing the memtest86+ it also worked in most scenarios, because it fallbacks to mtab. It didn't work as expected only in case when the root LABEL in fstab points to other device that the one currently mounted as root (very rare). I will probably remove this functionality in the future. memtest86+-4.10-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/memtest86+-4.10-4.fc14 memtest86+-4.10-4.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/memtest86+-4.10-4.fc13 Package memtest86+-4.10-4.fc14: * should fix your issue, * was pushed to the Fedora 14 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing memtest86+-4.10-4.fc14' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/memtest86+-4.10-4.fc14 then log in and leave karma (feedback). memtest86+-4.10-5.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. memtest86+-4.10-4.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. memtest86+-4.10-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |