Bug 672127
| Summary: | coloring of help message should be disabled if stdOUT is not a tty. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Masatake YAMATO <yamato> | ||||
| Component: | sos | Assignee: | Jean-Francois Saucier <jsaucier> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | bmr, dwmw2, jsaucier, prc | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-02-11 16:25:02 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Hello Masatake, Thank you for your contribution! I'd rather not modify __cmdLineOpts__ outside of command-line options, but reused sys.stdout.isatty(). Fixed upstream through https://fedorahosted.org/sos/changeset/1084 -- Pierre Carrier, Technical Support Engineer Production Support, EMEA office Global Support Services Red Hat, Inc. Thank you for fixing. Just a question. Why "Component" field for this bugzilla entry is changed from sos to 0xFFFF? Sorry, that's a browser-side bug. Oh, you should file a bug! What package is it?? |
Created attachment 474888 [details] A patch fix the issue. Description of problem: It is hard to read the output of "sosreport -l" if it is stored to file or is connected to the other command like "less" because escape characters for coloring are included in the output. Version-Release number of selected component (if applicable): The laster from svn repository. How reproducible: sosrepor -l > /tmp/foo less /tmp/foo Steps to Reproduce: 1. 2. 3. Actual results: Escape characters for coloring are included. Expected results: Escape characters for coloing are not included only when the stdout of sosreport is not connected to a terminal. Additional info: