Bug 672221
| Summary: | Review Request: sqlite3-dbf - Converter of XBase / FoxPro tables to SQLite | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pavel Alexeev <pahan> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, michel, notting |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | sqlite3-dbf-2011.01.24-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-21 01:26:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Pavel Alexeev
2011-01-24 13:02:33 UTC
Taking the review Almost everything looks good (typo on the comment for BuildRoot: still, not steel). APPROVED. Note that I've tested installing the built package but not actually doing a conversion -- I have no XBase/FoxPro sample tables at hand. updated URLs: spec: http://hubbitus.info/rpm/Fedora13/sqlite3-dbf/sqlite3-dbf.spec SRPM: http://hubbitus.info/rpm/Fedora13/sqlite3-dbf/sqlite3-dbf-2011.01.24-1.fc13.src.rpm #+TODO: TODO(t) WAIT(w@/!) FAIL(f@) | DONE(d) N/A(n) * TODO Review [90%] - [X] Names [2/2] - [X] Package name - [X] Spec name - [X] Package version [2/2] http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning - [X] Version number http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Version_Tag - [X] Release tag http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages - [X] Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]] - [X] Source files match upstream ✗ sha1sum sqlite3-dbf_2011.01.24.tar.gz ../SOURCES/sqlite3-dbf_2011.01.24.tar.gz 3081deeff2572579a6ccab765c3c8288f1dbba97 sqlite3-dbf_2011.01.24.tar.gz 3081deeff2572579a6ccab765c3c8288f1dbba97 ../SOURCES/sqlite3-dbf_2011.01.24.tar.gz - [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No bundled libraries]] - [X] License [4/4] - [X] License is Fedora-approved - [X] No licensing conflict - [X] License field accurate - [X] License included iff packaged by upstream - [X] rpmlint [2/2] - [X] on src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. - [X] on x86_64.rpm sqlite3-dbf.x86_64: W: no-manual-page-for-binary sqlite3-dbf 2 packages and 0 specfiles checked; 0 errors, 1 warnings. - [-] Language & locale [1/2] - [ ] Spec in US English in comment for BuildRoot, s|Steel|Still| - [X] Spec legible - [X] Build [3/3] - [X] Koji results http://koji.fedoraproject.org/koji/taskinfo?taskID=3762444 - [X] BRs complete - [X] Directory ownership - [X] Spec inspection [7/7] - [X] No duplicate files - [X] File permissions - [X] Filenames must be UTF-8 - [X] [RHEL] %clean section https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean) - [X] [RHEL 5] %buildroot cleaned on %install - [X] Macro usage consistent - [X] Documentation [1/1] - [X] %doc files are non-essential Thank you! I have fixed type. Thank you very much for the review! New Package SCM Request ======================= Package Name: sqlite3-dbf Short Description: Converter of XBase / FoxPro tables to SQLite Owners: hubbitus Branches: F-16 F-16 F-17 EL-5 EL-6 InitialCC: The branches have been renamed, they should be "f15 f16 el5 el6". I think f17 won't be branched for a few more days. Git done (by process-git-requests). sqlite3-dbf-2011.01.24-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/sqlite3-dbf-2011.01.24-1.el5 sqlite3-dbf-2011.01.24-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/sqlite3-dbf-2011.01.24-1.el6 sqlite3-dbf-2011.01.24-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/sqlite3-dbf-2011.01.24-1.fc16 sqlite3-dbf-2011.01.24-1.el6 has been pushed to the Fedora EPEL 6 testing repository. sqlite3-dbf-2011.01.24-1.fc16 has been pushed to the Fedora 16 stable repository. sqlite3-dbf-2011.01.24-1.el5 has been pushed to the Fedora EPEL 5 stable repository. sqlite3-dbf-2011.01.24-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |