Bug 672428 (CVE-2010-4655)

Summary:	CVE-2010-4655 kernel: heap contents leak for CAP_NET_ADMIN via ethtool ioctl
Product:	[Other] Security Response	Reporter:	Eugene Teo (Security Response) <eteo>
Component:	vulnerability	Assignee:	Red Hat Product Security <security-response-team>
Status:	CLOSED ERRATA	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	unspecified	CC:	arozansk, bhu, dhoward, jkacur, jolsa, kernel-mgr, kmcmartin, lgoncalv, lwang, plyons, rkhan, rt-maint, tcallawa, vgoyal, vkrizan, vmayatsk, williams, wnefal+redhatbugzilla
Target Milestone:	---	Keywords:	Security
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-07-29 13:42:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	672430, 672431, 672432, 672433, 672434, 672435, 672436
Bug Blocks:

Description Eugene Teo (Security Response) 2011-01-25 04:21:37 UTC

Several other ethtool functions leave heap uncleared (potentially) by drivers. Some interfaces appear safe (eeprom, etc), in that the sizes are well controlled. In some situations (e.g. unchecked error conditions), the heap will remain unchanged in areas before copying back to userspace. Note that these are less of an issue since these all require CAP_NET_ADMIN.

ethtool_get_rxfh_indir (intro in a5b6ee29 v2.6.36-rc1)
ethtool_get_rx_ntuple (intro in 15682bc4 v2.6.34-rc1)
ethtool_get_regs changed to vmalloc in a77f5db3 v2.6.37-rc1

Upstream commit:
http://git.kernel.org/linus/b00916b189d13a615ff05c9242201135992fcda3

Reference:
https://lkml.org/lkml/2010/10/7/297

Acknowledgements:

Red Hat would like to thank Kees Cook for reporting this issue.

Comment 3 Eugene Teo (Security Response) 2011-01-25 05:13:29 UTC

ethtool_get_rxfh_indir (introduced in a5b6ee29 v2.6.36-rc1)
ethtool_get_rx_ntuple (introduced in 15682bc4 v2.6.34-rc1)
ethtool_get_regs -> changed to vmalloc in a77f5db3 v2.6.37-rc1
   missing zeroing, posted a patch, see
   http://marc.info/?l=linux-kernel&m=129593098003553&w=2

ethtool_get_rx{fh_indir,_ntuple} are not backported to rhel-4/5/6/mrg-1. We just need to backport ethtool_get_regs() changes.

Comment 4 Eugene Teo (Security Response) 2011-01-28 01:43:52 UTC

(In reply to comment #3)
[...]
> ethtool_get_rx{fh_indir,_ntuple} are not backported to rhel-4/5/6/mrg-1. We
> just need to backport ethtool_get_regs() changes.

http://git.kernel.org/linus/b7c7d01aaed1f71d9afe815a569f0a81465a1744

Comment 5 errata-xmlrpc 2011-02-16 15:15:31 UTC

This issue has been addressed in following products:

  Red Hat Enterprise Linux 4

Via RHSA-2011:0263 https://rhn.redhat.com/errata/RHSA-2011-0263.html

Comment 6 errata-xmlrpc 2011-03-01 20:29:45 UTC

This issue has been addressed in following products:

  Red Hat Enterprise Linux 5

Via RHSA-2011:0303 https://rhn.redhat.com/errata/RHSA-2011-0303.html

Comment 7 errata-xmlrpc 2011-03-10 20:05:21 UTC

This issue has been addressed in following products:

  MRG for RHEL-5

Via RHSA-2011:0330 https://rhn.redhat.com/errata/RHSA-2011-0330.html

Comment 8 errata-xmlrpc 2011-04-08 02:57:41 UTC

This issue has been addressed in following products:

  Red Hat Enterprise Linux 6

Via RHSA-2011:0421 https://rhn.redhat.com/errata/RHSA-2011-0421.html