Bug 672441

Summary: Tracetool autogenerate qemu-kvm.stp with wrong qemu-kvm path
Product: Red Hat Enterprise Linux 6 Reporter: Mike Cao <bcao>
Component: qemu-kvmAssignee: Jes Sorensen <Jes.Sorensen>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: high Docs Contact:
Priority: high    
Version: 6.1CC: amit.shah, ehabkost, lcapitulino, michen, mjenner, mkenneth, tburke, virt-maint
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: qemu-kvm-0.12.1.2-2.147.el6 Doc Type: Bug Fix
Doc Text:
This is a fix to a problem introduced in an interim RHEL6.1 patch backport. It is not a regression from 6.0 and not customer exposed.
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-19 11:26:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Mike Cao 2011-01-25 05:11:06 UTC
Description of problem:
I saw tracetool regards the path of qemu-kvm as /usr/bin instead of /usr/libexec in 
/usr/share/systemtap/tapset/qemu-kvm.stp 
When I exec stp script call the tracepoint ,there is no output
eg:
probe qemu.kvm.qemu_memalign
{
	printf("qemu_memalign alignment=%d ,size=%d ,ptr=%p\n",alignment,size,ptr)
}

we need to change it to the right path.


Version-Release number of selected component (if applicable):
qemu-kvm-0.12.1.2-2.131.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1.cat qemu-kvm.stp |grep probe

  
Actual results:
probe qemu.kvm.qemu_malloc = process("/usr/bin/qemu-kvm").mark("qemu_malloc")
probe qemu.kvm.qemu_realloc = process("/usr/bin/qemu-kvm").mark("qemu_realloc")
probe qemu.kvm.qemu_free = process("/usr/bin/qemu-kvm").mark("qemu_free")
.....


Expected results:
all the /usr/bin/qemu-kvm should change to /usr/libexec/qemu-kvm
eg.
probe qemu.kvm.qemu_malloc = process("/usr/libexec/qemu-kvm").mark("qemu_malloc")
probe qemu.kvm.qemu_realloc = process("/usr/libexec/qemu-kvm").mark("qemu_realloc")
probe qemu.kvm.qemu_free = process("/usr/libexec/qemu-kvm").mark("qemu_free"


Additional info:

Comment 5 Mike Cao 2011-02-14 05:23:29 UTC
Tried on qemu-kvm-0.12.1.2-2.144.el6

Path changed to /usr/libexec/qemu-kvm in qemu-kvm.stp.

bcao--->jes
# cat /usr/share/systemtap/tapset/qemu-kvm.stp|grep probe
probe qemu.system.x86_64.qemu_malloc
probe qemu.system.x86_64.qemu_realloc
....

Why use "qemu.system.x86_64.XXX" instead of "probe qemu.kvm.XXXX" ?
Is it made by design or a regression ?

Mike

Comment 6 Jes Sorensen 2011-02-14 13:44:28 UTC
This is an additional bug related to the fix I posted with the patches
here.

I should have caught it when I posted the initial patch, but I only
looked at the path :(

I'll look into fixing this.

Comment 9 Mike Cao 2011-02-21 05:34:05 UTC
Verified on qemu-kvm-0.12.1.2-2.147.el6

Repeat the steps in comment #0.

Actual Results:
Path changed to /usr/libexec/qemu-kvm in qemu-kvm.stp.
"qemu.kvm.XXX" was used instead of "qemu.system.x86_64.XXX"


Based on above ,this issue has been fixed.

Comment 11 Miya Chen 2011-03-10 01:55:36 UTC
move to verified based on comment#9

Comment 12 Jes Sorensen 2011-05-05 17:27:23 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
This is a fix to a problem introduced in an interim RHEL6.1 patch backport. It is not a regression from 6.0 and not customer exposed.

Comment 13 errata-xmlrpc 2011-05-19 11:26:36 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0534.html

Comment 14 errata-xmlrpc 2011-05-19 13:01:21 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0534.html