| Summary: | Review Request: perl-Test-DistManifest - Author test that validates a package MANIFEST | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Pisar <ppisar> | ||||
| Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review, notting, paul | ||||
| Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | perl-Test-DistManifest-1.009-1.fc16 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-03-29 13:36:02 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Bug Depends On: | |||||||
| Bug Blocks: | 672561, 729653 | ||||||
| Attachments: |
|
||||||
|
Description
Petr Pisar
2011-01-25 14:21:12 UTC
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK
rpm -q perl-Test-DistManifest
perl-Test-DistManifest-1.009-1.fc15.noarch
rpm -q --provides perl-Test-DistManifest
perl(Test::DistManifest) = 1.009
perl-Test-DistManifest = 1.009-1.fc15
[root@arrakis ~]# rpm -q --requires perl-Test-DistManifest
perl(:MODULE_COMPAT_5.12.2)
perl(Module::Manifest) >= 0.07
perl(Test::Builder) >= 0.72
perl(Test::More) >= 0.62
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
perl(Carp)
perl(Cwd)
perl(File::Find)
perl(File::Spec)
perl(File::Spec::Unix)
perl(strict)
perl(warnings)
Please fix and file bug on rpmlint and rpmbuild ;-)
BuildArch: perl(File::Spec)
BuildArch: perl(File::Spec::Unix)
rpmlint reported as bug #672608, rpmbuild as bug #672605. New spec file and SRPM on the same URLs. I'm sorry for such delay. ACCEPT New Package SCM Request ======================= Package Name: perl-Test-DistManifest Short Description: Author test that validates a package MANIFEST Owners: ppisar mmaslano psabata Branches: InitialCC: perl-sig Git done (by process-git-requests). Thank you for the review and the repository. Could we have branches of this package for all currently-supported releases please (including EPEL)? If the ExtUtils::MakeMaker 6.31 requirement is patched out of Makefile.PL and the Test::More version requirement is ignored, this module works perfectly well all the way back to RHEL-3. I would be happy to maintain the older branches if you're not interested in them. I ask this so that I don't need to conditionalize inclusion of this package in my own packages, where I try to remain compatible with older release where possible. Created attachment 517591 [details]
Changes for EPEL 4/5 compatibility
Attached patch updates the package to be fully EPEL 4/5/6 compatible.
Package Change Request ====================== Package Name: perl-Test-DistManifest New Branches: el4 el5 el6 Owners: pghmcfc InitialCC: perl-sig [As a commaintainer of this package I opened git request. ] Thanks Marcela. Could you also request branches for F-14 and F-15 please? Package Change Request ====================== Package Name: perl-Test-DistManifest New Branches: f14 f15 Owners: pghmcfc mmaslano psabata ppisar InitialCC: perl-sig [I'd like f14 and f15 with these maintainers, el5 and el6 will be just pghmcfc.] Git done (by process-git-requests). I think you'll need to ask for the EPEL branches again Marcela. perl-Test-DistManifest-1.011-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Test-DistManifest-1.011-3.fc14 perl-Test-DistManifest-1.011-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Test-DistManifest-1.011-3.fc15 Package Change Request ====================== Package Name: perl-Test-DistManifest New Branches: el4 el5 el6 Owners: pghmcfc InitialCC: perl-sig This is a resubmission of Marcela's request from Comment #9, which was missed due to the addition of Comment #11. Git done (by process-git-requests). perl-Test-DistManifest-1.011-4.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Test-DistManifest-1.011-4.el5 perl-Test-DistManifest-1.011-4.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/perl-Test-DistManifest-1.011-4.el4 perl-Test-DistManifest-1.011-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Test-DistManifest-1.011-4.el6 Builds are now done and submitted as updates. Buildroot overrides would now be nice so that potential reviewers of perl-Pod-Wordlist-hanekomu (Bug #729653) can do scratch builds... perl-Test-DistManifest-1.011-3.fc14 perl-Test-DistManifest-1.011-3.fc15 perl-Test-DistManifest-1.011-4.el4 perl-Test-DistManifest-1.011-4.el5 perl-Test-DistManifest-1.011-4.el6 perl-Test-DistManifest-1.011-3.fc15 has been pushed to the Fedora 15 stable repository. perl-Test-DistManifest-1.011-3.fc14 has been pushed to the Fedora 14 stable repository. perl-Test-DistManifest-1.011-4.el4 has been pushed to the Fedora EPEL 4 stable repository. perl-Test-DistManifest-1.011-4.el5 has been pushed to the Fedora EPEL 5 stable repository. perl-Test-DistManifest-1.011-4.el6 has been pushed to the Fedora EPEL 6 stable repository. |