Bug 672582

Summary: Review Request: perl-Perl-Critic-Nits - Policies of nits I like to pick
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Ruediger Landmann <rlandman>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, rlandman
Target Milestone: ---Flags: rlandman: fedora-review+
j: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Perl-Critic-Nits-1.0.0-1.fc16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-03-15 17:45:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 690569    

Description Petr Pisar 2011-01-25 16:42:15 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-Perl-Critic-Nits/perl-Perl-Critic-Nits.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-Perl-Critic-Nits/perl-Perl-Critic-Nits-1.0.0-1.fc15.src.rpm
Description:
The included policy is:
Perl::Critic::Policy::ValuesAndExpressions::ProhibitAccessOfPrivateData
(Prohibits direct access to a hash-based object's hash).

Comment 1 Ruediger Landmann 2011-03-15 05:29:01 UTC
Thanks Petr -- nice and clean :)

ACCEPT

 - = N/A
 / = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [/] Rpmlint output is clean:
$ rpmlint SPECS/perl-Perl-Critic-Nits.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint SRPMS/perl-Perl-Critic-Nits-1.0.0-1.fc14.src.rpm
perl-Perl-Critic-Nits.src: W: spelling-error %description -l en_US ValuesAndExpressions -> Expressions, Expressionistic, Expressionless
perl-Perl-Critic-Nits.src: W: spelling-error %description -l en_US ProhibitAccessOfPrivateData 
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
$ rpmlint RPMS/noarch/perl-Perl-Critic-Nits-1.0.0-1.fc14.noarch.rpm
perl-Perl-Critic-Nits.noarch: W: spelling-error %description -l en_US ProhibitAccessOfPrivateData 
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

 [/] Package is named according to the Package Naming Guidelines.
 [/] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [/] Package meets the Packaging Guidelines including the Language specific
items
 [/] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [/] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic

 [-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [/] Spec file is legible and written in American English.
 [/] Sources used to build the package matches the upstream source, as provided
in the spec URL.
$ md5sum SOURCES/Perl-Critic-Nits-v1.0.0.tar.gz 
e31188815713b86eb57a8889f19c45b2  SOURCES/Perl-Critic-Nits-v1.0.0.tar.gz
$ md5sum ~/Download/Perl-Critic-Nits-v1.0.0.tar.gz 
e31188815713b86eb57a8889f19c45b2  /home/rlandmann/Download/Perl-Critic-Nits-v1.0.0.tar.gz

 [/] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=2912776
 [/] Package is not known to require ExcludeArch
 [/] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly (with the %find_lang macro)
 [-] ldconfig called in %post and %postun if required.
 [/] Package does not bundle copies of system libraries
 [/] Package is not relocatable.
 [/] Package must own all directories that it creates.
 [/] Package does not contain duplicates in %files.
 [/] Permissions on files are set properly
 [/] %files section includes a %defattr(...) line
 [/] Package consistently uses macros.
 [-] Large documentation files are in a -doc subpackage, if required.
 [/] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -static subpackage, if present.
 [-] Development .so files in -devel subpackage, if present.
 [-] -devel packages require base package with full versioning.
 [/] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [/] Package does not own files or directories owned by other packages.
 [/] Filenames are valid UTF-8

Comment 2 Petr Pisar 2011-03-15 09:12:41 UTC
New Package SCM Request
=======================
Package Name: perl-Perl-Critic-Nits
Short Description: Policies of nits I like to pick
Owners: ppisar, mmaslano, psabata
Branches: 
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2011-03-15 15:25:11 UTC
Git done (by process-git-requests).

Comment 4 Petr Pisar 2011-03-15 17:45:55 UTC
Thank you for the review and the repository.