Bug 672850

Summary: /var/cache/pungi/createrepocache grows without limit
Product: [Fedora] Fedora Reporter: John Reiser <jreiser>
Component: pungiAssignee: Dennis Gilmore <dennis>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: dcantrell
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-02-17 13:35:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description John Reiser 2011-01-26 15:28:51 UTC
Description of problem: The directory /var/cache/pungi/createrepocache grows without limit.  Mine was 1.4MB with tens of thousands of very small files from all the pungi runs that I had done since installing.  Most of the entries were stale; they refered to rpms that were no longer in any other subdirectory /var/cache/pungi/<repo>/packages.  Also, a directory with that many entries is a performance sink, even with hashed lookups.  


Version-Release number of selected component (if applicable):
pungi-2.5-1.fc15

How reproducible: every time


Steps to Reproduce:
1. Compose install DVD of rawhide using pungi.  Note size of /var/cache/pungi/createrepocache.
2. Wait a day or two until rawhide changes enough to change the install DVD, then repeat step 1.
3. Run "repomanage -o /var/cache/pungi/rawhide/packages" and remove old .rpms.
4. Run step 1 again, and note that createrepocache still has entries for .rpms that were removed in step 3.
  
Actual results: createrepocache grows without limit.


Expected results: createrepocache should be pruned by pungi itself.


Additional info:

Comment 1 Jesse Keating 2011-01-26 17:35:15 UTC
Since the cache is used for all possible composes, and people often name the repos the same thing in their configs even if they point at different locations, I can't come up with a good way to safely prune that stuff.  If you have suggestions, I'll listening.

Comment 2 John Reiser 2011-01-26 20:10:05 UTC
Because the files and filenames in the createrepocache directory depend only on the contents of each .rpm and on its n-v-r, and not on any other part of the pathname to the .rpm, then:

1. Prune an entry (unlink it) if the last access to it was more than 10 days ago.

2. Scan the directory (look for entries to prune) whenever the number of entries in the createrepocache directory is more than 2.2 times the number of packages for the current compose.  Composes which use a small number of .rpms will scan "unfairly" often if the same cache also is used by composes of a large number of .rpms, but the cost of scanning is small compared to the cost of using a very large directory with many stale entries.

Also, the manual page should mention the maintenance aspects of createrepocache.

Comment 3 Jesse Keating 2011-01-26 23:42:16 UTC
These still sound like risky things, or rather things that are not a normal part of the pungi run state.  I think at most I'd like to suggest a simple command line that somebody could run to prune the cache mentioned in the man page.

Comment 4 Fedora Admin XMLRPC Client 2012-02-10 18:58:37 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 5 Fedora End Of Life 2013-04-03 14:28:35 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 6 Fedora End Of Life 2015-01-09 16:31:55 UTC
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 7 Fedora End Of Life 2015-02-17 13:35:29 UTC
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.