| Summary: | Review Request: perl-Pango - Perl interface to the pango library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Pango-1.221-2.fc15 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-03-29 03:49:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Tom "spot" Callaway
2011-01-26 21:04:37 UTC
Builds fine; rpmlint says:
perl-Pango.x86_64: W: private-shared-object-provides
/usr/lib64/perl5/vendor_perl/auto/Pango/Pango.so Pango.so()(64bit)
perl-Pango.x86_64: W: private-shared-object-provides
/usr/lib64/perl5/vendor_perl/auto/Pango/Pango.so Pango.so()(64bit)
These should probably be filtered. %{?perl_default_filter} should take care of it.
perl-Pango.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/perl5/vendor_perl/Pango/Install/pango-perl-autogen.h
perl-Pango.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/perl5/vendor_perl/Pango/Install/pango-perl.h
perl-Pango.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/perl5/vendor_perl/Pango/Install/pango-perl-versions.h
These are OK.
Note that rpm finds a dependency on perl(Glib) itself, so your manual one results in a duplicate. Not really sure why it doesn't find any dependency on perl(Cairo).
Anyway, the duplicate isn't really a problem as long as it's needed to force an update, though it does reveal an issue: F13 only has perl-Glib 1.201. (It's never actually been built for F13.) You're the maintainer so I guess updating it shouldn't be an issue.
* source files match upstream. sha256sum:
af524d0b6749fb5762f1152dbe02ed547a2a7308a1f667fce96cfbb2ca7d25c6
Pango-1.221.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
X rpmlint has valid complaints.
* final provides and requires are sane:
Pango.so()(64bit)
perl(Pango) = 1.221
perl(Pango::Install::Files)
perl-Pango = 1.221-1.fc15
perl-Pango(x86-64) = 1.221-1.fc15
=
libcairo.so.2()(64bit)
libfreetype.so.6()(64bit)
libglib-2.0.so.0()(64bit)
libgmodule-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libgthread-2.0.so.0()(64bit)
libpango-1.0.so.0()(64bit)
libpangocairo-1.0.so.0()(64bit)
perl >= 0:5.008
perl(:MODULE_COMPAT_5.12.3)
perl(Cairo) >= 1.000
perl(DynaLoader)
perl(Exporter)
perl(Glib)
perl(Glib) >= 1.220
perl(strict)
perl(warnings)
* no bundled libraries.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no static libraries.
* no libtool .la files.
Apologies for the delay. Good catch on perl-Glib, i'll get it sync'd up. The other items are fixed in -2: New SRPM: http://www.auroralinux.org/people/spot/review/new/perl-Pango-1.221-2.fc14.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/new/perl-Pango.spec And I apologize for the delay on my end. I've carved out some time and gotten my buildsys back up and running so I can finally finish this off. Basically, everything looks good to me. I would normally suggest turning on a but more verbosity in the build process, but I couldn't find an easy way to do so besides passing NOECHO= on the make line, which made the output rather messy. Maybe there's some recent Makefile.PL magic I don't know about. But that's certainly not a big deal. APPROVED New Package SCM Request ======================= Package Name: perl-Pango Short Description: Perl interface to the pango library Owners: spot Branches: f13 f14 f15 InitialCC: perl-sig Git done (by process-git-requests). perl-Pango-1.221-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Pango-1.221-2.fc15 perl-Pango-1.221-2.fc15 has been pushed to the Fedora 15 testing repository. perl-Pango-1.221-2.fc15 has been pushed to the Fedora 15 stable repository. Package Change Request ====================== Package Name: perl-Pango New Branches: el6 Owners: spot Git done (by process-git-requests). |