Bug 673115

This package looks alright. Setting review+.

New Package SCM Request
=======================
Package Name: dee-qt
Short Description: Qt bindings and QML plugin for Dee
Owners: jreznik
Branches: f14
InitialCC: 

PS: f14 branch only for fedpkg bug, no intentions to push it there.

Could we get some actual review here?  Given that the package fails to meet the naming guidelines (as there's no date in the package version), I'm not sure how much review was actually done.

(In reply to comment #3)
> Could we get some actual review here?  Given that the package fails to meet the
> naming guidelines (as there's no date in the package version), I'm not sure how
> much review was actually done.

Ok, my fault here doing the actual review over IRC and not updating it in actual review.

For naming guidelines - I omit date as I think it's useless information when the revision is used. But I agree - this should be bring to FPC table and changed in naming guidelines. Sorry for that.

Package update to final release (using Ubuntu's sources as they don't care
currently about non-Ubuntu users)

Spec URL: http://rezza.hofyland.cz/fedora/packages/dee-qt/dee-qt.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/dee-qt/dee-qt-0.2-1.fc14.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2881824

Looks like there's again demand for Unity 2d stack on fedora-ml, so let's continue with refreshed package.

Spec URL: http://rezza.hofyland.cz/fedora/packages/dee-qt/dee-qt.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/dee-qt/dee-qt-0.2.3-1.fc16.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3738920

rpmlint dee-qt-0.2.3-1.fc16.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



==== C/C++ ====
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST ldconfig called in %post and %postun if required.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.
[!]: MUST Development .so files in -devel subpackage, if present.
     Note: dee-qt-0.2.3-1.fc17.i686.rpm :
     /usr/lib/qt4/imports/dee/libQtDeeQml.so
-> Qt plugin, so doesn't matter

==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.

rpmlint dee-qt-debuginfo-0.2.3-1.fc17.i686.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


rpmlint dee-qt-0.2.3-1.fc17.i686.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


rpmlint dee-qt-0.2.3-1.fc17.src.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


rpmlint dee-qt-devel-0.2.3-1.fc17.i686.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/radek/review/673115/libqtdee_0.2.3.orig.tar.gz :
  MD5SUM this package     : d60c0ea3ecbb5a6154bf0d878474e694
  MD5SUM upstream package : d60c0ea3ecbb5a6154bf0d878474e694

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: SHOULD Scriptlets must be sane, if used.
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
     Note: Source0:
     https://launchpad.net/ubuntu/precise/+source/libqtdee/0.2.3-0ubuntu2/+files/libqtdee_0.2.3.orig.tar.gz
     (libqtdee_0.2.3.orig.tar.gz) Patch0: dee-qt-0.1.bzr25-libdir-suffix.patch
     (dee-qt-0.1.bzr25-libdir-suffix.patch)
-> Upstream doesn't provide separate tarball, taken from ubuntu package
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[ ]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.

Issues:
[!]: MUST Development .so files in -devel subpackage, if present.
     Note: dee-qt-0.2.3-1.fc17.i686.rpm :
     /usr/lib/qt4/imports/dee/libQtDeeQml.so


Generated by fedora-review 0.1.2
External plugins:


No issues found, confirming fedora-review+.

New Package SCM Request
=======================
Package Name: dee-qt
Short Description: Qt bindings and QML plugin for Dee
Owners: jreznik
Branches: f16
InitialCC:

Git done (by process-git-requests).

This package has never been built and later removed:

commit 2ec1b6225a08b70bbb348c8b1d9727b01b916331 (HEAD -> master, origin/master, origin/HEAD)
Author: Jaroslav Reznik <jreznik>
Date:   Wed Jun 11 11:15:19 2014 +0200

    Not actually imported - discontinued project