| Summary: | Review Request: perl-Perl-Critic-Bangs - Collection of handy Perl::Critic policies | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Pisar <ppisar> |
| Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Perl-Critic-Bangs-1.06-1.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-03-07 16:41:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 690569 | ||
|
Description
Petr Pisar
2011-01-27 17:24:14 UTC
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
(GPL+ or Artistic 2.0 in main pm file, in other files are GPLv3 or Artistic 2.0)
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK
rpm -qp --provides perl-Perl-Critic-Bangs-1.06-1.fc14.noarch.rpm
perl(Perl::Critic::Bangs) = 1.06
perl(Perl::Critic::Policy::Bangs::ProhibitCommentedOutCode) = 1.06
perl(Perl::Critic::Policy::Bangs::ProhibitFlagComments) = 1.06
perl(Perl::Critic::Policy::Bangs::ProhibitNoPlan) = 1.06
perl(Perl::Critic::Policy::Bangs::ProhibitNumberedNames) = 1.06
perl(Perl::Critic::Policy::Bangs::ProhibitRefProtoOrProto) = 1.06
perl(Perl::Critic::Policy::Bangs::ProhibitUselessRegexModifiers) = 1.06
perl(Perl::Critic::Policy::Bangs::ProhibitVagueNames) = 1.06
perl-Perl-Critic-Bangs = 1.06-1.fc14
rpm -qp --requires perl-Perl-Critic-Bangs-1.06-1.fc14.noarch.rpm
perl(:MODULE_COMPAT_5.12.3)
perl(Perl::Critic) >= 1.098
perl(Perl::Critic::Policy)
perl(Perl::Critic::Utils)
perl(Perl::Critic::Utils::PPIRegexp)
perl(Readonly)
perl(Test::More)
perl(Test::Perl::Critic) >= 1.01
perl(base)
perl(strict)
perl(warnings)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
ACCEPT (after build pass in koji, blocking package is still not in buildroot)
New Package SCM Request ======================= Package Name: perl-Perl-Critic-Bangs Short Description: Collection of handy Perl::Critic policies Owners: ppisar, mmaslano, psabata Branches: InitialCC: perl-sig Git done (by process-git-requests). The dependency in Bugzilla was bogus. Thanks for review and repository. |