Bug 673463

Summary: Fail to save any changes for overview page in guest details
Product: Red Hat Enterprise Linux 6 Reporter: Cui Chun <ccui>
Component: virt-managerAssignee: Cole Robinson <crobinso>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: high Docs Contact:
Priority: high    
Version: 6.1CC: dyuan, hjiang, llim, mjenner, xen-maint, yimwang
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-19 13:47:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Virt-manager debug info
none
Fix error when applying changes from overview page none

Description Cui Chun 2011-01-28 10:16:16 UTC
Description of problem:

The "Apply" button is invalid for overview page in guest details when access a guest via virt-manager UI. 


Version-Release number of selected component (if applicable):

libvirt-0.8.7-4.el6
qemu-kvm-0.12.1.2-2.132.el6
kernel-2.6.32-94.el6
virt-manager-0.8.6-1.el6

How reproducible:
Always.

Steps to Reproduce:
1. Select the existing VM from virt-manager UI, then "open" -> "details" -> "Overview" 

2. Modify "Description" or "Security" and click "Apply" button. 

3. Check the changes from guest xml file. No any change is updated to xml file.
  
Actual results:

Refer to step3.

Expected results:

"Apply" button is worked. 


Additional info:

Comment 2 Cole Robinson 2011-02-22 14:43:17 UTC
Is the VM running or not? Can you please post the output of virt-manager --debug when reproducing?

Comment 3 Cui Chun 2011-02-23 02:58:24 UTC
Created attachment 480315 [details]
Virt-manager debug info

Comment 4 Cui Chun 2011-02-23 03:01:26 UTC
The VM is not running when tried to change "Security" option. 
It is also invalid for running VM. 
Please check "Virt-manager debug info" attachment.

----debug info ----
....
if self.window.get_widget("security-type-box").get_sensitive():
AttributeError: 'gtk.Table' object has no attribute 'get_sensitive'
.....

Comment 5 Cole Robinson 2011-02-24 16:49:12 UTC
Created attachment 480805 [details]
Fix error when applying changes from overview page

Comment 6 Cole Robinson 2011-02-24 16:52:17 UTC
Fix built in virt-manager-0.8.6-2

Comment 8 wangyimiao 2011-03-08 07:38:03 UTC
Verfied it on build :
virt-manager-0.8.6-2.el6.noarch
libvirt-0.8.7-10.el6.x86_64
qemu-kvm-0.12.1.2-2.149.el6.x86_64
kernel-2.6.32-118.el6.x86_64

Steps:
1. Prepare an VM which is not running.
#setenforce 1

2. Issue "virt-manager" to open virt-manager UI.

3. Select the existing VM, then "open" -> "details" -> "Overview" -> "Security"

4. Select "static" option, then specify a label,and apply it.

such as: "system_u:system_r:svirt_t:s0:c100,c200"

5. Change context of guest image file, such as:

# chcon system_u:object_r:svirt_image_t:s0:c100,c200 /var/lib/libvirt/images/nfs_test.img

6. Start the vm.
# virsh start nfs_test
Domain nfs_test started

7. Check svirt label of the qemu-kvm process.

#ps -efZ|grep qemu-kvm
system_u:system_r:svirt_t:s0:c100,c200 qemu 6092   1 79 07:32 ?  
.................................

#  ls -Z /var/lib/libvirt/images/nfs_test.img 
-rw-r--r--. qemu qemu system_u:object_r:svirt_image_t:s0:c100,c200 /var/lib/libvirt/images/nfs_test.img

Comment 11 Huming Jiang 2011-03-16 06:44:07 UTC
Verfied it on build :
virt-manager-0.8.6-3.el6.noarch
libvirt-0.8.7-11.el6.x86_64
qemu-kvm-0.12.1.2-2.150.el6.x86_64
kernel-2.6.32-120.el6.x86_64

Steps:
1. Prepare an VM which is not running;

2. Issue "virt-manager" to open virt-manager UI;

3. Select the existing VM, then "open" -> "details" -> "Overview" -> "Description";

4. Change the content as "test for bug 673463", and then "apply" it, power on the guest machine;

5. Input "virsh edit rrr(my guest vm)" in the terminal to check the info.
# virsh edit rrr
domain type='kvm'>
  <name>rrr</name>
  <uuid>34d72740-9d97-1626-c53a-1b0f82d80491</uuid>
  <description>test for bug 673463</description>
  <memory>1048576</memory>

6. repeat 1-5, the changed info has been updated to xml file.

Comment 12 dyuan 2011-03-16 13:28:31 UTC
According to the comment 11, move the bug status to VERIFIED.

Comment 13 errata-xmlrpc 2011-05-19 13:47:45 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0637.html