Bug 673468

Summary: [abrt] system-config-printer-1.2.5-8.fc14: in Connection_deletePrinterFromClass() at cupsconnection.c:3342
Product: [Fedora] Fedora Reporter: abugreporter
Component: system-config-printerAssignee: Tim Waugh <twaugh>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 14CC: jpopelka, twaugh
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard: abrt_hash:4982ce6ed334d5d1c2a4d812294711e40d66a902
Fixed In Version: system-config-printer-1.2.8-1.fc13 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-04-29 03:21:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
File: backtrace none

Description abugreporter 2011-01-28 10:25:29 UTC
abrt version: 1.1.14
architecture: x86_64
Attached file: backtrace
cmdline: /usr/bin/python /usr/share/system-config-printer/system-config-printer.py
component: system-config-printer
crash_function: Connection_deletePrinterFromClass
executable: /usr/bin/python
kernel: 2.6.35.10-74.fc14.x86_64
package: system-config-printer-1.2.5-8.fc14
rating: 4
reason: Process /usr/bin/python was killed by signal 11 (SIGSEGV)
release: Fedora release 14 (Laughlin)
How to reproduce: I tried to delete a printer, but I got a crash instead. 
time: 1296209529
uid: 500

Comment 1 abugreporter 2011-01-28 10:25:32 UTC
Created attachment 475770 [details]
File: backtrace

Comment 2 Tim Waugh 2011-02-03 12:39:04 UTC
    printers = ippFindAttribute (answer, "member-uris", IPP_TAG_URI);
    newlist = ippAddStrings (request, IPP_TAG_PRINTER, IPP_TAG_URI,
			     "member-uris", printers->num_values - 1,
			     NULL, NULL);

rax            0x0	0
[...]
   0x00007f4756de0d5c <+652>:	lea    0xaef7(%rip),%rsi        # 0x7f4756debc5a
   0x00007f4756de0d63 <+659>:	mov    $0x45,%edx
   0x00007f4756de0d68 <+664>:	mov    %r13,%rdi
   0x00007f4756de0d6b <+667>:	callq  0x7f4756dda7c0 <ippFindAttribute@plt>
=> 0x00007f4756de0d70 <+672>:	mov    0x18(%rax),%r8d
   0x00007f4756de0d74 <+676>:	lea    0xaedf(%rip),%rcx        # 0x7f4756debc5a
   0x00007f4756de0d7b <+683>:	xor    %r9d,%r9d
   0x00007f4756de0d7e <+686>:	mov    $0x45,%edx
   0x00007f4756de0d83 <+691>:	mov    $0x4,%esi
   0x00007f4756de0d88 <+696>:	mov    %r15,%rdi
   0x00007f4756de0d8b <+699>:	mov    %rax,%r12
   0x00007f4756de0d8e <+702>:	movq   $0x0,(%rsp)
   0x00007f4756de0d96 <+710>:	sub    $0x1,%r8d
   0x00007f4756de0d9a <+714>:	callq  0x7f4756dda6e0 <ippAddStrings@plt>

So ippFindAttribute() returned NULL.  I can't really think of a reason that would happen, but I've put in a check for that now upstream.

Fixed in 4952f2b320c5c64891c5ec4b818ff52eb42bb061.

Comment 3 Fedora Update System 2011-04-05 12:39:59 UTC
system-config-printer-1.2.8-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/system-config-printer-1.2.8-1.fc14

Comment 4 Fedora Update System 2011-04-05 12:44:57 UTC
system-config-printer-1.2.8-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/system-config-printer-1.2.8-1.fc13

Comment 5 Fedora Update System 2011-04-06 22:29:49 UTC
Package system-config-printer-1.2.8-1.fc13:
* should fix your issue,
* was pushed to the Fedora 13 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing system-config-printer-1.2.8-1.fc13'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/system-config-printer-1.2.8-1.fc13
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2011-04-29 03:21:17 UTC
system-config-printer-1.2.8-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2011-05-09 20:55:45 UTC
system-config-printer-1.2.8-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.