Bug 673502

Summary:	unclear error when wallaby feature-import is run with no file name
Product:	Red Hat Enterprise MRG	Reporter:	Lubos Trilety <ltrilety>
Component:	condor-wallaby-tools	Assignee:	Will Benton <willb>
Status:	CLOSED ERRATA	QA Contact:	Tomas Rusnak <trusnak>
Severity:	low	Docs Contact:
Priority:	low
Version:	1.3	CC:	iboverma, jneedle, matt, mhusnain, trusnak, willb
Target Milestone:	2.0
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	wallaby-0.10.4-3	Doc Type:	Bug Fix
Doc Text:	C: Running "wallaby feature-import" without a file name may have resulted in an unclear internal error message. C: This is confusing for users. F: "wallaby feature-import" now traps the error appropriately and displays a suitable, clear error message. R: The feature-import command now exits with a user-friendly error message in this case. Release Note Entry: Previously, running the "wallaby feature-import" command without supplying a file name resulted in an unclear error message. The "wallaby feature-import" command can now trap the error to display a clearer error message when run without a file name.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-06-23 15:42:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	693778

Description Lubos Trilety 2011-01-28 13:42:56 UTC

Description of problem:
'wallaby feature-import' run with no file name prints following error:
fatal:  #<TypeError: can't convert nil into String>
It will be better if it prints something like: A file name must be specified

Version-Release number of selected component (if applicable):
wallaby-0.10.4-2

How reproducible:


Steps to Reproduce:
1. run 'wallaby feature-import'
# wallaby feature-import
fatal:  #<TypeError: can't convert nil into String>

Comment 3 Will Benton 2011-03-15 04:14:31 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
C: Running "wallaby feature-import" without a file name may have resulted in an unclear internal error message.
C: This is confusing for users.
F: "wallaby feature-import" now traps the error appropriately and displays a suitable, clear error message.
R: The feature-import command now exits with a user-friendly error message in this case.

Comment 4 Tomas Rusnak 2011-04-20 14:01:48 UTC

Retested over all supported archs x86,x86_64 with RHEL5/RHEL6: 

#  rpm -q wallaby-utils
wallaby-utils-0.10.5-3.el6.noarch

# wallaby feature-import
fatal:  you must specify exactly one file name (use --help for more information)

>>> VERIFIED

Comment 5 Misha H. Ali 2011-05-27 04:09:57 UTC

    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,4 +1,6 @@
 C: Running "wallaby feature-import" without a file name may have resulted in an unclear internal error message.
 C: This is confusing for users.
 F: "wallaby feature-import" now traps the error appropriately and displays a suitable, clear error message.
-R: The feature-import command now exits with a user-friendly error message in this case.+R: The feature-import command now exits with a user-friendly error message in this case.
+
+Release Note Entry: Previously, running the "wallaby feature-import" command without supplying a file name resulted in an unclear error message. The "wallaby feature-import" command can now trap the error to display a clearer error message when run without a file name.

Comment 6 Misha H. Ali 2011-06-06 03:23:09 UTC

Technical note can be viewed in the release notes for 2.0 at the documentation stage here:

http://documentation-stage.bne.redhat.com/docs/en-US/Red_Hat_Enterprise_MRG/2.0/html-single/MRG_Release_Notes/index.html#tabl-MRG_Release_Notes-GRID_Update_Notes-RHM_Known_Issues

Comment 7 errata-xmlrpc 2011-06-23 15:42:17 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHEA-2011-0889.html