Bug 673919

Summary: Review Request: monkey - Very small, fast and scalable web server for Linux.
Product: [Fedora] Fedora Reporter: Antonio Sebastián Sallés <asalles.mail>
Component: Package ReviewAssignee: Guillermo Gómez <guillermo.gomez>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: rawhideCC: asalles.mail, fedora-package-review, guillermo.gomez, mmcallis, msuchy, notting, pahan
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-02-19 05:45:46 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On:    
Bug Blocks: 201449    

Description Antonio Sebastián Sallés 2011-01-31 00:06:57 EST
Spec URL: http://rpmdev.proyectofedora.org/attachments/download/294/monkey.spec
SRPM URL:
http://rpmdev.proyectofedora.org/attachments/download/292/monkey-0.12.2-1.fc14.src.rpm
Description: Monkey is a very Fast and Lightweight Web Server (HTTP SERVER) for GNU/Linux platforms. It tries to take the most of Linux Kernel to deliver a great performance and as opposite to many other similar projects, Monkey is not portable between different operative systems as it depends of specific Linux system calls. Also, Monkey can be easily extended, it provides a flexible API to create plugins which are loaded on startup per configuration.
What make it so fast ?, It's written in C and use an hybrid networking model based on fixed threads, polling and asynchrounous calls, providing a real scalable web server with low CPU and memory consumption. Performance is our main goal.


More information in:
http://www.monkey-project.com/downloads

Please, I need a sponsor.
Thanks a lot!
Comment 1 Guillermo Gómez 2011-02-08 16:49:12 EST
I'll review in parallel with Toshio.
Comment 2 Guillermo Gómez 2011-02-09 13:29:52 EST
MUST
----
rpmlint output - MISSING

Package name - OK

Spec file matches base package - OK

License must be licensed with a Fedora approved license and meet the Licensing
Guidelines - OK

License in spec must match actual license - OK

License file include in %doc - OK

Spec file written in American English - OK

Spec file legible - OK

Tar ball matches upstream - OK

Package successfully builds binary RPMs - OK (koji f13,f14, local f14 x86_64)

No duplicate files - OK

Macro use must be consistant - OK

At the beginning of %install, each package MUST run rm -rf %{buildroot} - OK

All filenames in rpm packages must be valid UTF-8 - OK

Your package should contain man pages for binaries/scripts. If it doesn't, work
with upstream to add them where they make sense - SHOULD

/etc/rc.d/init.d/banana sysv initscript provided but not configured.

Please follow http://fedoraproject.org/wiki/Packaging:SysVInitScript to include the initscript.
Comment 3 Miroslav Suchý 2012-12-16 07:55:16 EST
Ping? Any progress here? Or we can close this review?
Comment 4 Miroslav Suchý 2013-02-19 05:45:46 EST
Stalled Review. Closing per:
https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
If you ever want to continue in this review, please reopen or
submit new review.
Comment 5 Murray McAllister 2014-08-19 04:37:01 EDT
Hello,

If this gets reopened, please try to include a fix for this issue before releasing the package in Fedora:

http://www.openwall.com/lists/oss-security/2014/08/18/5

Thanks,

--
Murray McAllister / Red Hat Product Security