Bug 673919
Summary: | Review Request: monkey - Very small, fast and scalable web server for Linux. | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Antonio Sebastián Sallés <asalles.mail> |
Component: | Package Review | Assignee: | Guillermo Gómez <guillermo.gomez> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | low | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | asalles.mail, fedora-package-review, guillermo.gomez, mmcallis, msuchy, notting, pahan |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-02-19 10:45:46 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 201449 |
Description
Antonio Sebastián Sallés
2011-01-31 05:06:57 UTC
I'll review in parallel with Toshio. MUST ---- rpmlint output - MISSING Package name - OK Spec file matches base package - OK License must be licensed with a Fedora approved license and meet the Licensing Guidelines - OK License in spec must match actual license - OK License file include in %doc - OK Spec file written in American English - OK Spec file legible - OK Tar ball matches upstream - OK Package successfully builds binary RPMs - OK (koji f13,f14, local f14 x86_64) No duplicate files - OK Macro use must be consistant - OK At the beginning of %install, each package MUST run rm -rf %{buildroot} - OK All filenames in rpm packages must be valid UTF-8 - OK Your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense - SHOULD /etc/rc.d/init.d/banana sysv initscript provided but not configured. Please follow http://fedoraproject.org/wiki/Packaging:SysVInitScript to include the initscript. Ping? Any progress here? Or we can close this review? Stalled Review. Closing per: https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews If you ever want to continue in this review, please reopen or submit new review. Hello, If this gets reopened, please try to include a fix for this issue before releasing the package in Fedora: http://www.openwall.com/lists/oss-security/2014/08/18/5 Thanks, -- Murray McAllister / Red Hat Product Security |