Bug 674009
Summary: | Review Request: bitten - A continuous integration plugin for Trac | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Tim Niemueller <tim> |
Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, lemenkov, notting |
Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | bitten-0.6b3-0.3.fc14 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-03-04 09:53:20 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Tim Niemueller
2011-01-31 10:18:21 UTC
I'll review it Koji scratchbuild for F-15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2836716 REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable +/- rpmlint is NOT silent sulaco ~: rpmlint Desktop/bitten-* bitten.src: W: spelling-error Summary(en_US) plugin -> plug in, plug-in, plugging bitten-master.noarch: W: spelling-error Summary(en_US) plugin -> plug in, plug-in, plugging bitten-master.noarch: W: no-documentation bitten-master.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bitten/templates/bitten_admin_configs.html bitten-master.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bitten/templates/bitten_config.html bitten-master.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bitten/templates/bitten_summary_coverage.html bitten-master.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bitten/templates/bitten_admin_master.html bitten-master.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bitten/templates/bitten_summary_tests.html bitten-master.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bitten/templates/bitten_build.html bitten-slave.noarch: W: no-documentation bitten-slave.noarch: E: non-readable /etc/bitten-slave.conf 0640 bitten-slave.noarch: W: no-manual-page-for-binary bitten-slave ^^^ these messages already explained in the comment above. bitten-slave.noarch: W: dangerous-command-in-%postun userdel ^^^ Deleting users automatically is a very very bad practice and should be omitted entirely. I strongly encourage you to remove the '%postun slave' section entirely. Let system administrator to decide whether or not to remove users from the system. 4 packages and 0 specfiles checked; 7 errors, 6 warnings. sulaco ~: + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (3-clause BSD). + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. sulaco ~/rpmbuild/SOURCES: sha256sum Bitten-0.6b3.tar.gz* d3167fe928bb8d61e4367d71a6c286915c58f435b155c1886e0fea141f0501a8 Bitten-0.6b3.tar.gz d3167fe928bb8d61e4367d71a6c286915c58f435b155c1886e0fea141f0501a8 Bitten-0.6b3.tar.gz.1 sulaco ~/rpmbuild/SOURCES: + The package successfully compiles and builds into binary rpms on at least one primary architecture. See koji links above. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files. + The package does NOT bundle copies of system libraries. + The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. Ok, the only issue is the user removal during uninstalling - please, remove it. I have modified the postun script to print a reminder that the user should be deleted if no longer used. Updated spec in place, new SRPM is at http://fedorapeople.org/~timn/bitten/bitten-0.6b3-0.2.fc14.src.rpm OK, looks good now. I can't find any other issues, so this package is APPROVED. Thanks for the thorough review. New Package SCM Request ======================= Package Name: bitten Short Description: A continuous integration plugin for Trac Owners: timn Branches: f14 f15 el5 el6 InitialCC: Git done (by process-git-requests). bitten-0.6b3-0.3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/bitten-0.6b3-0.3.fc14 bitten-0.6b3-0.3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/bitten-0.6b3-0.3.fc15 bitten-0.6b3-0.3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/bitten-0.6b3-0.3.el5 bitten-0.6b3-0.3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/bitten-0.6b3-0.3.el6 bitten-0.6b3-0.3.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update bitten'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/bitten-0.6b3-0.3.fc14 bitten-0.6b3-0.3.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. bitten-0.6b3-0.3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. bitten-0.6b3-0.3.el5 has been pushed to the Fedora EPEL 5 stable repository. bitten-0.6b3-0.3.el6 has been pushed to the Fedora EPEL 6 stable repository. Package Change Request ====================== Package Name: bitten New Branches: epel7 Owners: timn Git done (by process-git-requests). |