Bug 674080

Summary:	Review Request: rubygem-acts_as_audited - Ruby extension logging all changes to your models in an audits table
Product:	[Fedora] Fedora	Reporter:	Lukas Zapletal <lzap>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bkabrda, fedora-package-review, notting, vondruch
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-08-03 15:05:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lukas Zapletal 2011-01-31 15:34:21 UTC

Spec URL: http://static.zapletalovi.com/fedora/rpm/rubygem-acts_as_audited/1.1.1-1/rubygem-acts_as_audited.spec
SRPM URL: http://static.zapletalovi.com/fedora/rpm/rubygem-acts_as_audited/1.1.1-1/rubygem-acts_as_audited-1.1.1-1.fc14.src.rpm
Description: 
ActiveRecord extension that logs all changes to your models in an audits table

# rpmlint rubygem-acts_as_audited-1.1.1-1.fc14.src.rpm 
rubygem-acts_as_audited.src: I: enchant-dictionary-not-found en_US
rubygem-acts_as_audited.src: W: no-%prep-section
rubygem-acts_as_audited.src: W: no-%build-section
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

# rpmlint rubygem-acts_as_audited-1.1.1-1.fc14.noarch.rpm
rubygem-acts_as_audited.noarch: I: enchant-dictionary-not-found en_US
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Bohuslav "Slavek" Kabrda 2011-09-07 08:12:42 UTC

Unofficial review:
* License seems to be wrong - Public Domain should be used.
* rpmlint complains about no %prep and %build. I suggest using at least %prep, because if any patches come into play, it would be wise to apply them in %prep.
* Consider adding CHANGELOG to %doc.
* rpmbuild complains about files being listed twice - README and LICENSE. I don't think this is a very big problem, but it can be solved by excluding them from %{geminstdir} and leaving them only in %doc (same for the CHANGELOG, if you add it to %doc).
* Otherwise, everything seems to be ok.

Comment 2 Bohuslav "Slavek" Kabrda 2011-09-07 10:43:31 UTC

Errata:
* The license is really MIT, sorry.

Additional comments:
* The first two lines (definition of %ruby_sitelib and %ruby_sitearch is not necessarry in this spec file.
* Have you tested the app with Rails 3?
* Consider using %dir %{geminstdir} instead of %{geminstdir} in files - it solves the problem with files being listed multiple times.
* You should use ruby(rubygems) in Require instead of just rubygems.
* Include BuildRequires: ruby.
* The %defattr(-, root, root, -) in %files section is not needed.
* You should include %check section and run the tests (something like RUBYOPT="I%{buildroot}%{geminstdir}/lib Itest" testrb test/*_test.rb should do).
* Reference to koji task: https://koji.fedoraproject.org/koji/taskinfo?taskID=3332026

Comment 3 Lukas Zapletal 2012-08-03 15:05:56 UTC

Since many things changed in the Ruby packaging I am closing this one for now. We will make brand new gem2rpm round. I apologize for not reacting.