Bug 674149

Summary:	Need a cleaner error message when feed type is not given
Product:	[Retired] Pulp	Reporter:	Preethi Thomas <pthomas>
Component:	z_other	Assignee:	Pradeep Kilambi <pkilambi>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Preethi Thomas <pthomas>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	skarmark
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-08-16 12:09:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	647488

Description Preethi Thomas 2011-01-31 19:05:16 UTC

Description of problem:
[root@preethi ~]# rpm -q pulp
pulp-0.0.132-1.fc14.noarch

[root@preethi ~]# pulp-admin repo create --id=pulp-repo --name=pulp-repo --feed=http://repos.fedorapeople.org/repos/pulp/pulp/ --relativepath=/tmp/ --groupid=pulp --schedule="2 * * * *"
error: operation failed: Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/pulp/server/webservices/controllers/base.py", line 57, in report_error
    return method(self, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/pulp/server/webservices/role_check.py", line 131, in check_roles
    result = f(instance, *fargs, **kw)
  File "/usr/lib/python2.7/site-packages/pulp/server/webservices/controllers/repositories.py", line 104, in PUT
    gpgkeys=repo_data.get('gpgkeys', None),)
  File "/usr/lib/python2.7/site-packages/pulp/server/compat.py", line 40, in _decorator
    return decorator(*args,**kwargs)
  File "/usr/lib/python2.7/site-packages/pulp/server/auditing.py", line 207, in _audit
    result = method(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/pulp/server/api/repo.py", line 131, in create
    r = model.Repo(id, name, arch, feed)
  File "/usr/lib/python2.7/site-packages/pulp/server/db/model/resource.py", line 163, in __init__
    self.source = RepoSource(source)
  File "/usr/lib/python2.7/site-packages/pulp/server/db/model/resource.py", line 204, in __init__
    self.parse_feed(url)
  File "/usr/lib/python2.7/site-packages/pulp/server/db/model/resource.py", line 213, in parse_feed
    % self.supported_types)
PulpException: "Invalid type.  valid types are ['yum', 'local', 'rhn']"



Expected results:


Additional info:

Comment 1 Sayli Karmarkar 2011-03-14 23:42:21 UTC

This seems to be fixed because of jconnor and jmatthews's fixes for server side
traceback.

$ sudo pulp-admin repo create --id=pulp-repo1 --name=pulp-repo --feed=http://repos.fedorapeople.org/repos/pulp/pulp/ --relativepath=/tmp/ --groupid=pulp --schedule="2 * * * *"
error: operation failed: PulpException: "Invalid type.  valid types are ['yum', 'local', 'rhn']"

Comment 2 Preethi Thomas 2011-03-25 19:59:23 UTC

verified

[root@preethi ~]# rpm -q pulp
pulp-0.0.157-1.git.1.1ea502c.fc14.noarch

[root@preethi ~]# pulp-admin repo create --id=pulp-repo1 --name=pulp-repo --feed=http://repos.fedorapeople.org/repos/pulp/pulp/ 
error: operation failed: A repository with the id, pulp-repo1, already exists
[root@preethi ~]#

Comment 3 Preethi Thomas 2011-08-16 12:09:44 UTC

Closing with Community Release 15

pulp-0.0.223-4.

Comment 4 Preethi Thomas 2011-08-16 12:22:05 UTC

Closing with Community Release 15

pulp-0.0.223-4.