Bug 674583

Summary:	qemu-kvm build fails without --enable-spice
Product:	Red Hat Enterprise Linux 6	Reporter:	Jes Sorensen <Jes.Sorensen>
Component:	qemu-kvm	Assignee:	Gerd Hoffmann <kraxel>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	6.1	CC:	akong, chayang, drjones, gcosta, juzhang, minovotn, mkenneth, tburke, virt-maint, wdai
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Unspecified
Whiteboard:
Fixed In Version:	qemu-kvm-0.12.1.2-2.233.el6	Doc Type:	Bug Fix
Doc Text:	No Documentation Needed	Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-06-20 11:32:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	580953

Description Jes Sorensen 2011-02-02 15:04:11 UTC

Description of problem:
Current rhel6-qemu-kvm fails to build when one does not specify --enable-spice
due to dummy wrapper macros returning a value. This fails when the macro
is called without storing the return value.

cc1: warnings being treated as errors
/home/jes/src/rhel6/qemu-kvm-rhel6/monitor.c: In function 'redhat_set_password':
/home/jes/src/rhel6/qemu-kvm-rhel6/monitor.c:1397: error: statement with no effect


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Gerd Hoffmann 2011-02-15 10:07:49 UTC

Fix: http://patchwork.ozlabs.org/patch/81327/

Comment 3 Gerd Hoffmann 2011-04-26 12:56:43 UTC

*** Bug 688037 has been marked as a duplicate of this bug. ***

Comment 12 Gerd Hoffmann 2011-09-20 13:13:45 UTC

Looks like commit 1c6074d107dff93c7c7b0edfb5da871504802946 added a dependency on spice.  That wasn't intentional.  Scheduling to fix for 6.3.

Comment 13 juzhang 2011-10-09 03:18:25 UTC

(In reply to comment #12)
> Looks like commit 1c6074d107dff93c7c7b0edfb5da871504802946 added a dependency
> on spice.  That wasn't intentional.  Scheduling to fix for 6.3.

Hi,Gerd

   Would you please tell me your plan?as you mentioned,you patch added a dependency on spice.do you plan to revert this patch or reserve this patch?
Would you please tell us in details?

Comment 14 Gerd Hoffmann 2011-10-10 08:37:05 UTC

Plan is to apply a patch which #ifdefs the spice bits with CONFIG_SPICE so no spice functions are called in case spice is disabled at compile time.

Comment 16 Gerd Hoffmann 2012-02-17 09:46:29 UTC

patch posted.

Comment 19 Chao Yang 2012-03-06 10:15:18 UTC

Verified this issue by the steps below:
1. git clone the latest qemu-kvm-rhel6 source code from ehabkost's tree
2. ./configure --disable-spice  --enable-werror
3. make && make install

Actual Result:
No spice related warning or error prompts, qemu-system-x86_64 is installed correctly. 
So, this issue has been fixed.

Comment 21 Michal Novotny 2012-05-03 17:04:30 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No Documentation Needed

Comment 22 errata-xmlrpc 2012-06-20 11:32:42 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0746.html