Bug 674600
| Summary: | checksum warning in credentials,py | ||
|---|---|---|---|
| Product: | [Retired] Pulp | Reporter: | Pradeep Kilambi <pkilambi> |
| Component: | z_other | Assignee: | Jeff Ortel <jortel> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Preethi Thomas <pthomas> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | unspecified | CC: | skarmark |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | Sprint 20 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-08-16 12:11:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 647488 | ||
Since pulp packages require hashlib and we already import directly and use in other places, I simply replaced sha with hashlib. Fixed: 0b2f7aaa4e2176997789dd20e615de8d728abfba This can be tested by creating/deleting a consumer and noting the consumer cert, key, pulp.rep are cleaned up. Fixed in 0.134. [root@preethi ~]# rpm -q pulp pulp-0.0.134-1.fc14.noarch [root@preethi ~]# pulp-admin -u admin -p admin repo create --id=tfoo --feed=local:blah Successfully created repository [ tfoo ] I still see this in the f13 pulp-server fails-qa [root@pulp-qe ~]# rpm -q pulp pulp-0.0.134-1.fc13.noarch [root@pulp-qe ~]# pulp-admin -u admin -p admin repo create --id=tfoo --feed=local:blah /usr/lib/python2.6/site-packages/pulp/client/credentials.py:21: DeprecationWarning: the sha module is deprecated; use the hashlib module instead import sha as SHA Successfully created repository [ tfoo ] The fix is on master but must have missed the 0.134 build. Perhaps I forget to push? Anyway, it really should be in 0.135 - putting back to MODIFIED. verified [root@pulp-qe ~]# rpm -q pulp pulp-0.0.135-1.fc13.noarch [root@pulp-qe ~]# pulp-admin -u admin -p admin repo create --id=testfoo --feed=local:blah checked the /usr/lib/python2.6/site-packages/pulp/client/credentials.py:21: import hashlib Closing with Community Release 15 pulp-0.0.223-4. Closing with Community Release 15 pulp-0.0.223-4. |
Description of problem: $ sudo pulp-admin -u admin -p admin repo create --id=tfoo --feed=local:blah /home/pkilambi/code/pulp/src/pulp/client/credentials.py:21: DeprecationWarning: the sha module is deprecated; use the hashlib module instead import sha as SHA We should not default to sha imports anymore. Newer versions of python enforce use of hashlib. We need a try except to use hashlib by default and if that fails use sha. something like: try: import hashlib except ImportError: import sha class hashlib: @staticmethod def new(checksum): if checksum == 'sha': return sha.new() and the code would invoke it as hashlib.new('sha')