Bug 674755

Summary: Fence password is printed to logs
Product: Red Hat Enterprise Linux 6 Reporter: Mike Kolesnik <mkolesni>
Component: vdsmAssignee: Dan Kenigsberg <danken>
Status: CLOSED CURRENTRELEASE QA Contact: yeylon <yeylon>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.0CC: abaron, bazulay, danken, iheim, ilvovsky, mgoldboi, rvaknin, srevivo, syeghiay
Target Milestone: rcKeywords: Regression, Security
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: vdsm-4.9-48.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-08-19 15:08:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Mike Kolesnik 2011-02-03 07:47:39 UTC
Description of problem:
When fencing a host, Notice that the first line prints the password but the second doesn't.
Thread-736761::DEBUG::2011-02-03 10:32:49,299::clientIF::40::vds::(wrapper) [10.35.1.69]::call fenceNode with ('10.35.18.55', '', 'ilo', 'USERID', 'PASSW0RD', 'off', '', 'ssl=no') {}
Thread-736761::DEBUG::2011-02-03 10:32:49,300::clientIF::1330::vds::(fenceNode) fenceNode(addr=10.35.18.55,port=,agent=ilo,user=USERID,passwd=XXXX,action=off,secure=,options=ssl=no)


Version-Release number of selected component (if applicable):


How reproducible:
Always


Steps to Reproduce:
1. Fence a host

  
Actual results:
The password is printed to the VDSM log.


Expected results:
The password must not be printed to the log.


Additional info:

Comment 5 Dan Kenigsberg 2011-02-10 09:03:48 UTC
that specific log line is removed.

Comment 6 Rami Vaknin 2011-02-14 13:16:42 UTC
Verified.

The following log does not contain any data that the next log miss so it's probably OK to remove it:

Thread-10842::DEBUG::2011-02-09 18:49:22,648::clientIF::41::vds::(wrapper) [10.35.116.100]::call fenceNode with ('rhev-i24c-02-drac.mpc.lab.eng.bos.redhat.com', '', 'ipmilan', 'root', 'calvin', 'status', '', '') {}



Thread-10842::DEBUG::2011-02-09 18:49:22,648::clientIF::1341::vds::(fenceNode) fenceNode(addr=rhev-i24c-02-drac.mpc.lab.eng.bos.redhat.com,port=,agent=ipmilan,user=root,passwd=XXXX,action=status,secure=,options=)