Bug 675121

Summary: Review Request: buildsys-macros - Build system macros
Product: Red Hat Enterprise Linux 5 Reporter: Daniel Mach <dmach>
Component: Package ReviewAssignee: Marcela Mašláňová <mmaslano>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 5.0CC: notting, pm-rhel
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: RHEL5.0-ACCEPT
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-02-24 14:19:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 188273, 613985    

Comment 2 Marcela Mašláňová 2011-02-04 12:16:13 UTC
- rpmlint:
buildsys-macros.src: W: no-version-in-last-changelog FIX
buildsys-macros.src: W: no-url-tag OK
- package must be named according to Guidelines  OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

rpm -qp --provides /usr/src/redhat/RPMS/noarch/buildsys-macros-5-5.el5.noarch.rpm 
buildsys-macros = 5-5.el5

rpm -qp --requires /usr/src/redhat/RPMS/noarch/buildsys-macros-5-5.el5.noarch.rpm 
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1

ACCEPT after FIX: add missing version in changelog
(Comment: there is no flack, which set package as approved).

Comment 3 Daniel Mach 2011-02-04 12:23:22 UTC
fixed, re-uploaded to previous location

$ rpmlint buildsys-macros-5-5.el5.src.rpm
buildsys-macros.src: W: no-url-tag
1 packages and 0 specfiles checked; 0 errors, 1 warnings.