Bug 675364

Summary: Review Request: perl-Digest-JHash - Perl extension for 32 bit Jenkins Hashing Algorithm
Product: [Fedora] Fedora Reporter: Ralf Corsepius <rc040203>
Component: Package ReviewAssignee: Iain Arnell <iarnell>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, iarnell, notting
Target Milestone: ---Flags: iarnell: fedora-review+
j: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-03-04 07:19:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Ralf Corsepius 2011-02-05 07:14:56 UTC 
Spec URL: http://corsepiu.fedorapeople.org/packages/perl-Digest-JHash.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-Digest-JHash-0.07-1.fc15.src.rpm

Description: 
The Digest::JHash module allows you to use the fast JHash hashing algorithm
developed by Bob Jenkins from within Perl programs. The algorithm takes as
input a message of arbitrary length and produces as output a 32-bit
"message digest" of the input in the form of an unsigned long integer.
Comment 1 Iain Arnell 2011-02-27 09:48:43 UTC 
+ source files match upstream.  
    273adb11b5c4701dc43273d82ab26dd9  Digest-JHash-0.07.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
    Artistic 2.0

+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ package builds in mock
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2869957

+ package installs properly.
+ rpmlint has no complaints:
    3 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ final provides and requires are sane:
    perl(Digest::JHash) = 0.07
    perl-Digest-JHash = 0.07-1.fc16
    perl-Digest-JHash(x86-64) = 0.07-1.fc16
=
    libc.so.6()(64bit)  
    libc.so.6(GLIBC_2.2.5)(64bit)  
    perl(DynaLoader)  
    perl(Exporter)  
    perl(:MODULE_COMPAT_5.12.3)  
    perl(strict)  
    perl(vars)  
    perl(warnings)  

+ %check is present and all tests pass.
    PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
    t/jhash.t ......... ok
    t/pod.t ........... ok
    t/pod_coverage.t .. ok
    All tests successful.
    Files=3, Tests=7,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.09 cusr  0.02 csys =  0.13 CPU)
    Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


A nice simple clean package. APPROVED.
Comment 2 Ralf Corsepius 2011-02-27 11:52:05 UTC 
Thanks again, Iain.

New Package SCM Request
=======================
Package Name: perl-Digest-JHash
Short Description: Perl extension for 32 bit Jenkins Hashing Algorithm
Owners: corsepiu
Branches: f13 f14 f15
InitialCC: perl-sig
Comment 3 Jason Tibbitts 2011-02-28 14:57:25 UTC 
Git done (by process-git-requests).