Bug 675706

Summary: pulp.client.connection.PulpConnection.shutDown() is never called
Product: [Retired] Pulp Reporter: Daniel Mach <dmach>
Component: user-experienceAssignee: Pradeep Kilambi <pkilambi>
Status: CLOSED CURRENTRELEASE QA Contact: Preethi Thomas <pthomas>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: tsanders
Target Milestone: ---Keywords: Triaged
Target Release: Sprint 20   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-08-16 12:10:56 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 563609, 647488    

Description Daniel Mach 2011-02-07 13:22:06 UTC
PulpConnection.shutDown() is never called and is broken.
It calls self.conn.close() while Reslib doesn't implement this method.

I recommend using pylint to catch such issues.

Comment 1 Pradeep Kilambi 2011-02-08 18:39:41 UTC
fixed!

commit e3661b387aafcbc82d599843169855605542f095
Author: Pradeep Kilambi <pkilambi>
Date:   Tue Feb 8 13:40:37 2011 -0500

Comment 2 Jay Dobies 2011-02-09 15:35:56 UTC
Fixed in 0.136.

Comment 3 Pradeep Kilambi 2011-02-09 18:56:36 UTC
To Test:

#!/usr/bin/python

from pulp.client import connection
conn = connection.PulpConnection()
conn.setUp()
conn.task_status("/repositories/")
conn.shutDown()

Make sure shutdown doesnt error with Attribute error

Comment 4 Preethi Thomas 2011-02-10 14:53:57 UTC
verified

[root@preethi ~]# rpm -q pulp
pulp-0.0.137-1.fc14.noarch
[root@preethi ~]# 

ran the above script without errors


[root@preethi ~]# python bug_675706.py 
[root@preethi ~]#

Comment 5 Preethi Thomas 2011-08-16 12:10:56 UTC
Closing with Community Release 15

pulp-0.0.223-4.

Comment 6 Preethi Thomas 2011-08-16 12:22:39 UTC
Closing with Community Release 15

pulp-0.0.223-4.