Bug 675726

few comments:

-- you should NOT point bash to Requires: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

-- if you don't plan package for EPEL you should not point BuildRoot and clean sections; 

-- you SHOULD point full URL to Source (vendor doen't prohibit it) http://cdm.ghost1227.com/repo/cdm-latest.tar.gz or http://cdm.ghost1227.com/repo/cdm-0.5.3.tar.gz

-- you SHOULD include README (create it) and COPYING  (license text  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text) to your package. You can include CHANGELOG too. 





-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Fixed 
Is README file neeeded?

New srpm
https://koji.fedoraproject.org/koji/getfile?taskID=2767219&name=cdm-0.5.3-2.fc14.src.rpm

Created attachment 477430 [details]
New spec file for build 2

I'll review it

Unblocking FE-NEEDSPONSOR - I just sponsored Mikhail.

Few notes before review:

* Please, drop commented out lines in the %install section

* Drop the following line as well

install -Dm644 src/xinitrc.skel $RPM_BUILD_ROOT/%{_docdir}/%{name}-%{version}/xinitrc.example

this file should be installed just as other docs (mark it as %doc in the %files section).

* The directory %{_datarootdir}/%{name}/ left unowned. Please apply the following change:

- %{_datarootdir}/%{name}/*
+ %{_datarootdir}/%{name}/

Note - trailing asterisk was removed.

Created attachment 477617 [details]
New spec v3

Fixed

https://koji.fedoraproject.org/koji/getfile?taskID=2784901&name=cdm-0.5.3-3.fc14.src.rpm

spec in attachments

Ok, few more notes:

* xinitrc must be installed into %{_datarootdir}/%{name}/ .
* Missing requires - dialog, xorg-x11-utils, dbus, xorg-x11-xinit
* cdmrc mentions 'awesome' as one of the window managers. Please change it to some more Fedora-specific.
* Licensing terms are misleading - the LICENSE file contains GPLv3, but the main script, ./src/cdm, explicitly menions GPLv2+. Please, contact upstream for clarification.

Fixed this issues.
Add ConsoleKit in requires list (it is used with dbus)
After discussion license issue was fixed - right license is GPLv2+ and now upstream sources have correct license text in tarbal.

SRPM URL: https://koji.fedoraproject.org/koji/getfile?taskID=2857478&name=cdm-0.5.3-4.fc14.src.rpm

spec file in attachment

Created attachment 480233 [details]
spec file v4

REVIEW:

Legend: + = PASSED, - = FAILED, 0 = Not Applicable

+ rpmlint is NOT silent but all its messages can be omitted in this case:

sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/noarch/cdm-0.5.3-4.fc15.noarch.rpm 
cdm.noarch: W: spelling-error Summary(en_US) minimalistic -> minimalist, minimalism, materialistic
cdm.noarch: W: spelling-error Summary(en_US) login -> loin, logic, lo gin
cdm.noarch: W: spelling-error %description -l en_US minimalistic -> minimalist, minimalism, materialistic
cdm.noarch: W: spelling-error %description -l en_US login -> loin, logic, lo gin
cdm.noarch: W: spelling-error %description -l en_US kdm -> km, Adm, Kim
cdm.noarch: W: spelling-error %description -l en_US gdm -> gm, gem, gum
cdm.noarch: W: spelling-error %description -l en_US qingy -> dingy, mingy, zingy

^^^ False positive.

cdm.noarch: W: non-conffile-in-etc /etc/profile.d/zzz-cdm-profile.sh

^^^ That's ok - this file is not intented to be changed by end-=user.

cdm.noarch: W: no-manual-page-for-binary cdm

^^^ Unfortunately this binary doesn't have corresponding man-page. So no luck for us here too.

1 packages and 0 specfiles checked; 0 errors, 9 warnings.
sulaco ~/rpmbuild/SPECS:

+ The package is named according to the  Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format %{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines.
+ The License field in the package spec file matches the actual license (GPLv2 or later).
+ The file, containing the text of the license(s) for the package, is included in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided in the spec URL.

sulaco ~/rpmbuild/SOURCES: sha256sum cdm-0.5.3.tar.gz*
fb9ada13d3416305828c99943698fe7df3b0ab91bd6099e7b2707e1d8dd99a23  cdm-0.5.3.tar.gz
fb9ada13d3416305828c99943698fe7df3b0ab91bd6099e7b2707e1d8dd99a23  cdm-0.5.3.tar.gz.1
sulaco ~/rpmbuild/SOURCES:

+ The package successfully compiles and builds into binary rpms on at least one primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Apparently, this packages is a GUI application, but we don't need a *.desktop file for starting it from other desktops.it. It is a desktop itself.
+ The package does not own files or directories already owned by other packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.

Ok, I can't find any other issues, so this package is

APPROVED.

New Package SCM Request
=======================
Package Name: cdm
Short Description: Very minimalistic login manager
Owners: mkulemin
Branches: f14 f15
InitialCC:

Git done (by process-git-requests).

cdm-0.5.3-4.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/cdm-0.5.3-4.fc14

cdm-0.5.3-4.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/cdm-0.5.3-4.fc15

cdm-0.5.3-4.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

cdm-0.5.3-4.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.