| Summary: | Review Request: perl-MDV-Packdrakeng - Simple Archive Extractor/Builder | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marcela Mašláňová <mmaslano> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora-package-review, notting, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-04-07 06:26:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 671389 | ||
|
Description
Marcela Mašláňová
2011-02-08 12:52:59 UTC
Source tar ball is original. Ok. Summary verified from lib/MDV/Packdrakeng.pm. Ok. License verified from lib/MDV/Packdrakeng.pm. Ok. No C binding, noarch BuildArch Ok. Description verified from lib/MDV/Packdrakeng.pm. Ok. TODO: BuildRequire perl(File::Path) (lib/MDV/Packdrakeng.pm:23) as the package can dual-live in the future (http://search.cpan.org/~dland/File-Path/). perl(Compress::Zlib) dependency (lib/MDV/Packdrakeng.pm:144) is optional. Ok. FIX: BuildRequire perl(Test::More) to proceed all tests (t/01packdrakeng.t:6). FIX: BuildRequire perl(Digest::MD5) to proceed all tests (t/01packdrakeng.t:7). TODO: BuildRequire perl(Compress::Zlib) to perform all tests (t/02methodusage.t:12). All tests pass. Ok. $ rpmlint perl-MDV-Packdrakeng.spec ../SRPMS/perl-MDV-Packdrakeng-1.13-1.fc14.src.rpm ../RPMS/noarch/perl-MDV-Packdrakeng-1.13-1.fc14.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-MDV-Packdrakeng-1.13-1.fc14.noarch.rpm drwxr-xr-x 2 root root 0 úno 8 14:38 /usr/share/doc/perl-MDV-Packdrakeng-1.13 -rw-r--r-- 1 root root 4065 srp 9 2007 /usr/share/doc/perl-MDV-Packdrakeng-1.13/ChangeLog -rw-r--r-- 1 root root 228 kvě 6 2007 /usr/share/doc/perl-MDV-Packdrakeng-1.13/README -rw-r--r-- 1 root root 4664 úno 8 14:38 /usr/share/man/man3/MDV::Packdrakeng.3pm.gz -rw-r--r-- 1 root root 1831 úno 8 14:38 /usr/share/man/man3/MDV::Packdrakeng::zlib.3pm.gz drwxr-xr-x 2 root root 0 úno 8 14:38 /usr/share/perl5/MDV drwxr-xr-x 2 root root 0 úno 8 14:38 /usr/share/perl5/MDV/Packdrakeng -rw-r--r-- 1 root root 30528 srp 9 2007 /usr/share/perl5/MDV/Packdrakeng.pm -rw-r--r-- 1 root root 7517 srp 9 2007 /usr/share/perl5/MDV/Packdrakeng/zlib.pm File permissions and layout Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-MDV-Packdrakeng-1.13-1.fc14.noarch.rpm | sort | uniq -c 1 perl(base) 1 perl(Compress::Zlib) 1 perl(File::Path) 1 perl(:MODULE_COMPAT_5.12.3) 1 perl(POSIX) 1 perl(strict) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 2 rpmlib(VersionedDependencies) <= 3.0.3-1 Binary requires Ok. rpm -q --provides -p ../RPMS/noarch/perl-MDV-Packdrakeng-1.13-1.fc14.noarch.rpm | sort | uniq -c 1 perl(MDV::Packdrakeng::zlib) 1 perl(MDV::Packdrakeng) = 1.13 1 perl-MDV-Packdrakeng = 1.13-1.fc14 Binary provides Ok. $ resolvedeps-f15 ../RPMS/noarch/perl-MDV-Packdrakeng-1.13-1.fc14.noarch.rpm Binary dependencies resolvable. Ok. FIX: Package does not build in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2784614). This is due to missing BuildRequires for tests. Othwerwise package is in line with Fedora and perl packaging guidelines. Please correct all `FIX' prefixed issues, consider fixing `TODO' prefixed issues, and provide new spec file. Resolution: Package NOT approved. BuilRequires were added. Build passed. http://koji.fedoraproject.org/koji/taskinfo?taskID=2963641 Spec file changes: --- perl-MDV-Packdrakeng.spec 2011-02-08 13:49:49.000000000 +0100 +++ perl-MDV-Packdrakeng.spec.1 2011-03-31 16:33:02.000000000 +0200 @@ -8,6 +8,10 @@ Source0: http://www.cpan.org/authors/id/N/NA/NANARDON/MDV-Packdrakeng-%{version}.tar.gz BuildArch: noarch BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(File::Path) +BuildRequires: perl(Digest::MD5) +BuildRequires: perl(Test::More) +BuildRequires: perl(Compress::Zlib) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) %description > TODO: BuildRequire perl(File::Path) (lib/MDV/Packdrakeng.pm:23) as the package > can dual-live in the future (http://search.cpan.org/~dland/File-Path/). +BuildRequires: perl(File::Path) Ok. > FIX: BuildRequire perl(Test::More) to proceed all tests (t/01packdrakeng.t:6). +BuildRequires: perl(Test::More) Ok. > FIX: BuildRequire perl(Digest::MD5) to proceed all tests > (t/01packdrakeng.t:7). +BuildRequires: perl(Digest::MD5) Ok. > TODO: BuildRequire perl(Compress::Zlib) to perform all tests > (t/02methodusage.t:12). +BuildRequires: perl(Compress::Zlib) Ok. Package builds in F16 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2965999). Ok. All tests are performed in Koji. Ok. Resolution: Package APPROVED. New Package SCM Request ======================= Package Name: perl-MDV-Packdrakeng Short Description: Simple Archive Extractor/Builder Owners: mmaslano psabata ppisar Branches: InitialCC: perl-sig Git done (by process-git-requests). |