Bug 676134

Andy, 

There are a few more patches (accepted upstream) which we dont think are critical but since you are picking some enic patches we were wondering if these can go in as well. 

0eb2602238e5aa33e0571a76aaf51a30bf32c3c2 enic: Clean up: Remove support for an older version of hardware
69161425800ac6cc28ac448bef5f21d09cb4f92a enic: Bug Fix: Reorder firmware devcmds - CMD_INIT and CMD_IG_VLAN_REWRITE_MODE
115d56f723c45088ddf46fac1ebba7c333039150 enic: Bug Fix: Fix return values of enic_add/del_station_addr routines
519874619f642afaf61530b0f4df3cd1e9a319e4 enic: Clean up: Organize devcmd wrapper routines

If you are ok taking these and need another bugzilla, I can create a new one. 

Thanks!.

Roopa, we can use the same bug for all of these changes.

I just needed a new bug for these since the old one already had changes committed for it.

This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux maintenance release. Product Management has 
requested further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed 
products. This request is not yet committed for inclusion in an Update release.

(In reply to comment #3)
> Roopa, we can use the same bug for all of these changes.
> 
> I just needed a new bug for these since the old one already had changes
> committed for it.


ok i filed a new one for  these: https://bugzilla.redhat.com/show_bug.cgi?id=676705

Thanks andy!

Roopa, was there a reason not to include this patch?

8a375557e303e4d082612bc3d79b23502a2a2a38 enic: Decouple mac address registration and deregistration from port profile set operation

Andy, we definitely need that one. I did not put that in here because in one of the comments you hinted you can put it along the below bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=641092

Or maybe i misunderstood. 

This is an imp patch...so please include it with which ever patch you think is reasonable.

Thanks!.

Created attachment 478936 [details]
update to upstream version 2.1.1.6

OK, initial testing looks good.  This is the patch I will propose on top of what we already have in RHEL6.

*** Bug 676705 has been marked as a duplicate of this bug. ***

Roopa, I closed 676705 as I didn't communicate clearly that this bug would be fine for all enic patches you have mentioned.

I changed the title of this bug indicating we will take all upstream changes that will take enic to version 2.1.1.6.

Thats perfect. Thanks Andy!.

(In reply to comment #12)
> Thats perfect. Thanks Andy!.

Glad to do it!

Thank you got letting me know quickly that there were beneficial fixes that we did not have.

Andy, Below are a few more small fixes committed today. They update enic driver to version 2.1.1.9. Let me know if you want me to open a new bugzilla. Thanks much.

1cbb1a61d59b7552e1e3fde485d8af5699fe16e0 enic: Always use single transmit and single receive hardware queues per device
5990b1892bbd0bb3adfc9a09bb3bcbde32471e59 enic: Clean up: Remove a not needed #ifdef
e0afe53fbea3823a1b1faef8d7701dd73bb74d5c enic: Bug fix: Reset driver count of registered unicast addresses to zero during devic

(In reply to comment #14)
> Andy, Below are a few more small fixes committed today. They update enic driver
> to version 2.1.1.9. Let me know if you want me to open a new bugzilla. Thanks
> much.
> 
> 1cbb1a61d59b7552e1e3fde485d8af5699fe16e0 enic: Always use single transmit and
> single receive hardware queues per device
> 5990b1892bbd0bb3adfc9a09bb3bcbde32471e59 enic: Clean up: Remove a not needed
> #ifdef
> e0afe53fbea3823a1b1faef8d7701dd73bb74d5c enic: Bug fix: Reset driver count of
> registered unicast addresses to zero during devic

Andy, Did you get a chance to pull the above ?. 
I have another one committed last week (Updates enic to 2.1.1.10):
"4d8340df77fa3e2d2d6f2bd287b6b20917a46a1e enic: Flush driver cache of registered addr lists during port profile disassociate"

Thanks,
Roopa

Roopa, I did post some patches, but did not include the ones in comment #14 or comment #15.  I can re-post my patch and consider adding them if you feel they are critical.

Andy, thanks for your response. Yes the patches are critical. Some of them the cleanup ones are probably not. But there is dependency between them..so its probably easier to pick them all.

Thanks.
Roopa

Created attachment 482956 [details]
update to upstream version 2.1.1.10

Roopa, this is the patch I proposed today for inclusion in RHEL6.1.  Thanks for letting us know about these additional fixes.

Thanks Andy. Looks great.

Patch(es) available on kernel-2.6.32-128.el6

Hi Roopa ,
This bug needs to be partner verified.

Verified. 
Checked that all requested patches have made it to 2.6.32-131.0.5 (RHEL 6.1 snap5) kernel.

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0542.html