Bug 676387
Summary: | Missing include in nss-softokn-freebl-devel subpackage of nss-softokn | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 6 | Reporter: | Elio Maldonado Batiz <emaldona> | ||||||||
Component: | nss-softokn | Assignee: | Elio Maldonado Batiz <emaldona> | ||||||||
Status: | CLOSED ERRATA | QA Contact: | Aleš Mareček <amarecek> | ||||||||
Severity: | medium | Docs Contact: | |||||||||
Priority: | medium | ||||||||||
Version: | 6.1 | CC: | amarecek, emaldona, kengert, rrelyea, stefanb | ||||||||
Target Milestone: | rc | ||||||||||
Target Release: | --- | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | nss-3.12.9-3.el6, nss-softokn-3.12.9-2.el6 | Doc Type: | Bug Fix | ||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | 675196 | Environment: | |||||||||
Last Closed: | 2011-05-19 14:03:54 UTC | Type: | --- | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Bug Depends On: | 675196 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Elio Maldonado Batiz
2011-02-09 17:19:26 UTC
This doesn't not involve any code changes, it's is strictly a packaging bug. It's solved by adding the needed header to the list of files to include in the spec file. Created attachment 477871 [details]
add missing header to the proper places the spec file
stefanb suggested adding to nss-softoken-devel a dependency on nss-softokn-devel I think it would be something like Requires: nss-softokn-devel%{?_isa} = %{version}-%{release} or maybe BuildRequires: nss-softokn-devel%{?_isa} = %{version}-%{release} I think you mean : stefanb suggested adding to nss-softokn-freebl-devel a dependency on nss-softokn-devel. I think that is incorrect, unless we mistakenly have headers in softokn that are included by freebl. The real dependency is the other way around (nss-softokn and nss-sofokn-devel depend on nss-softokn-freebl and nss-softokn-freebl-devel respectively). bob Comment on attachment 477871 [details]
add missing header to the proper places the spec file
r+
What you say in 5 what stefanb means is correct. Let me show: #> rpm -q --whatprovides /usr/include/nss3/blapi.h nss-softokn-freebl-devel-3.12.9-2.fc14.x86_64 In blapi.h the following is found [...] #ifndef _BLAPI_H_ #define _BLAPI_H_ #include "blapit.h" #include "hasht.h" #include "alghmac.h" [...] Let me check what provides blapit.h ... -> rpm -q --whatprovides /usr/include/nss3/blapit.h nss-softokn-devel-3.12.9-2.fc14.x86_64 I conclude freebl-devel has a dependency on nss-softokn-devel, yet I can do: root@d941e-5 patches]# yum remove nss-softokn-devel Loaded plugins: fastestmirror, presto, refresh-packagekit Setting up Remove Process Resolving Dependencies --> Running transaction check ---> Package nss-softokn-devel.x86_64 0:3.12.9-2.fc14 set to be erased --> Finished Dependency Resolution Dependencies Resolved ==================================================================================================== Package Arch Version Repository Size ==================================================================================================== Removing: nss-softokn-devel x86_64 3.12.9-2.fc14 @updates 52 k Transaction Summary ==================================================================================================== Remove 1 Package(s) Installed size: 52 k I would expect nss-softokn-devel also to uninstall nss-softokn-freebl-devel. > -> rpm -q --whatprovides /usr/include/nss3/blapit.h
> nss-softokn-devel-3.12.9-2.fc14.x86_64
Sigh, that should have been in nss-softokn-freebl-devel, not nss-softoken-devel
bob
Created attachment 478325 [details]
V2: blapit.h is now in the nss-softokn-freebl-devel file list.
Caveat: By making nss-softokn-freebl-devel the owner of blaphit.h, could we be introducing an implied dependency of nss-softokn-devel on nss-softokn-freebl? I find such a dependency undesirable since when it was a goal not do so and keep nss-softokn-freebl-devel a strictly optional. I'll test this in fedora first. Stefan, you are welcome to join me. I'll point you to a fedora scratch build. Created attachment 478944 [details]
V3 - proposed changes revised (change logs not included)
Expanded freel-devel description, added another requires, and concatenated associated patch for nss spec to take due nss-pkcs11-devel's dependency as Bob pointed out.
Comment on attachment 478944 [details]
V3 - proposed changes revised (change logs not included)
Expanded description for freebl-devel, added a requires, and concatenated nss spec change to account for pkcs11-devel dependency as Bob pointed out.
Comment on attachment 478944 [details]
V3 - proposed changes revised (change logs not included)
Combined hanges for nss-softokn and nss spec files. Exanded freebl-devel description, added devel dependency on freebl-devel due to blapit.h's "adoption" by freebl-devel, and added needed pkcs11-devel requires as Bob has pointed out.
Comment on attachment 478944 [details]
V3 - proposed changes revised (change logs not included)
r+ thanks for sussing this out.
Correction: in nss.spec for %package pkcs11-devel, the line Requires: nss-softokn-pkcs11-devel = %{version}-%{release} should have been Requires: nss-softokn-freel-devel = %{version}-%{release} as this one now provides the blapit.h header that nss-pks11-devel needs. Bad fingers: s/freel/freebl/ Comment on attachment 478944 [details] V3 - proposed changes revised (change logs not included) Since nss and nss-softokn keep their own versions, the requires for pk11-devel must be >+Requires: nss-softokn-freebl-devel = %{nss_softokn_version} I am using nss-config --cflags now to determine the additional cflags necessary for freebl includes (/usr/include/nss3). The nss-config tool comes with nss-devel. The issue is that the dependencies don't reach that far that when I require nss-softokn-freebl-devel that automatically nss-devel becomes a dependency. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2011-0692.html |