Bug 676411

Summary:	condor_trigger_config returns 0 even if trigger operations fail
Product:	Red Hat Enterprise MRG	Reporter:	Luigi Toscano <ltoscano>
Component:	condor-qmf	Assignee:	Robert Rati <rrati>
Status:	CLOSED ERRATA	QA Contact:	Tomas Rusnak <trusnak>
Severity:	low	Docs Contact:
Priority:	low
Version:	1.3	CC:	iboverma, matt, trusnak
Target Milestone:	2.0
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	condor-7.5.6-0.1	Doc Type:	Bug Fix
Doc Text:	C: A failure when executing condor_trigger_config C: The condor_trigger_config returns success F: The condor_trigger_config tool will exit with a failure R: A failure when executing condor_trigger_config would result in a failure return code	Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-06-23 15:41:45 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:	692158
Bug Blocks:	693778

Description Luigi Toscano 2011-02-09 19:08:38 UTC

Description of problem:
condor_trigger_config returns 0 also when trigger addition/removal/listing/testing fail. It only returns 1 when the the broker can't be reached.

Version-Release number of selected component (if applicable):
condor-qmf-7.4.5-0.8

Comment 1 Robert Rati 2011-02-24 17:05:24 UTC

Fixed upstream for 7.6.0

Comment 2 Robert Rati 2011-03-15 17:21:14 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
C: A failure when executing condor_trigger_config
C: The condor_trigger_config returns success
F: The condor_trigger_config tool will exit with a failure
R: A failure when executing condor_trigger_config would result in a failure return code

Comment 4 Tomas Rusnak 2011-05-26 12:37:35 UTC

Retested over all supported platforms x86,x86_64:

condor-qmf-7.6.1-0.6.el5
condor-qmf-7.6.1-0.6.el6.i686
condor-qmf-7.6.1-0.6.el6.x86_64

# condor_trigger_config -a -n test -q test -t test localhost
Connecting to broker 'localhost'...
No condor trigger service found
# echo $?
1
# condor_trigger_config -d 1 localhost
Connecting to broker 'localhost'...
No condor trigger service found
# echo $?
1
# condor_trigger_config -s localhost
Connecting to broker 'localhost'...
Received 'bind' event, ignoring
Received 'bind' event, ignoring
Received 'bind' event, ignoring
Testing triggers...
Listing currently installed triggers...
No triggers currently installed
No condor trigger service found
No condor trigger service found
Error: Interval was not set to 5 seconds
No condor trigger service found
# echo $?
1
# condor_trigger_config -l localhost
Connecting to broker 'localhost'...
Listing currently installed triggers...
No triggers currently installed
# echo $?
0

At last one the -l switch, the return code 0 is ok, there was nothing to list. Every other switches returned right error code.

>>> VERIFIED

Comment 5 errata-xmlrpc 2011-06-23 15:41:45 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHEA-2011-0889.html