| Summary: | Review Request: rubygem-delayed_job - Database-backed asynchronous priority queue system -- Extracted from Shopify | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vít Ondruch <vondruch> |
| Component: | Package Review | Assignee: | Mo Morsi <mmorsi> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mmorsi, notting |
| Target Milestone: | --- | Flags: | mmorsi:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-07-26 11:11:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Vít Ondruch
2011-02-10 12:07:29 UTC
Taking this one. Overall looks good
- the latest upstream release is 2.1.4, please consider updating
- could you remove references in the summary / description to 'shopify'
- the rspec2 components are now in fedora, can we drop the patch to the spec suite?
- there is one rpmlint warning to note:
rubygem-delayed_job.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/delayed_job-2.1.3/lib/generators/delayed_job/templates/script 0644L /usr/bin/env
- defaultattr is no longer necessary in files section an should be removed
- the package should own the %dir %{geminstdir} should it not
Package builds fine in koji.
I have uploaded updated version of delayed_job: Spec URL: http://people.redhat.com/vondruch/rubygem-delayed_job.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-delayed_job-2.1.4-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3227264 (In reply to comment #1) > Taking this one. Overall looks good > > - the latest upstream release is 2.1.4, please consider updating done > - could you remove references in the summary / description to 'shopify' done > - the rspec2 components are now in fedora, can we drop the patch to the spec > suite? done > - there is one rpmlint warning to note: > rubygem-delayed_job.noarch: E: non-executable-script > /usr/lib/ruby/gems/1.8/gems/delayed_job-2.1.3/lib/generators/delayed_job/templates/script > 0644L /usr/bin/env Actually this is Rails generator template, therefore it contains shebang, while it is not intended to be executed from current location, so the error is false positive. > - defaultattr is no longer necessary in files section an should be removed done > - the package should own the %dir %{geminstdir} should it not done Looks good. APPROVED. Thank you for your review! New Package SCM Request ======================= Package Name: rubygem-delayed_job Short Description: Database-backed asynchronous priority queue system Owners: vondruch Branches: InitialCC: Git done (by process-git-requests). |