Bug 676686

Summary:	virsh attach-interface regression
Product:	Red Hat Enterprise Linux 6	Reporter:	Eric Blake <eblake>
Component:	libvirt	Assignee:	Eric Blake <eblake>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.1	CC:	ccui, dallan, dyuan, eblake, gsun, jdenemar, mjenner, mzhan, xen-maint
Target Milestone:	rc	Keywords:	Regression
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-0.8.7-6.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-05-19 13:27:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Eric Blake 2011-02-10 19:16:42 UTC

Description of problem:
One of the patches applied for bug 646895 caused a regression in 'virsh attach-interface'.

Version-Release number of selected component (if applicable):
libvirt-0.8.7-5.el6

How reproducible:
100%

Steps to Reproduce:
1. virsh attach-interface RHEL6RC network default
  
Actual results:
error: Failed to attach interface
error: internal error unable to execute QEMU command 'device_add': Bus 'pci' not found


Expected results:
should work

Additional info:
Upstream report and patches:
https://www.redhat.com/archives/libvir-list/2011-February/msg00291.html

Comment 2 Eric Blake 2011-02-10 23:15:41 UTC

in POST: http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-February/msg00886.html

Comment 3 Jiri Denemark 2011-02-11 07:56:20 UTC

*** Bug 676548 has been marked as a duplicate of this bug. ***

Comment 6 Min Zhan 2011-02-12 04:55:06 UTC

Verified as Passed in below environment:
# uname -a
Linux dhcp-65-85.nay.redhat.com 2.6.32-112.el6.x86_64 #1 SMP Wed Feb 2 14:17:15 EST 2011 x86_64 x86_64 x86_64 GNU/Linux
kernel-2.6.32-112.el6.x86_64
qemu-kvm-0.12.1.2-2.132.el6.x86_64
libvirt-0.8.7-6.el6.x86_64

Steps:
1. Make sure the guest is in running
# virsh start rhel6
Domain rhel6 started

# virsh dumpxml rhel6 |grep network
    <interface type='network'>
      <source network='default'/>

2. Attach the interface
# virsh attach-interface rhel6 network default
Interface attached successfully

# virsh dumpxml rhel6 
...
    <interface type='network'>
      <mac address='52:54:00:5f:c1:6f'/>
      <source network='default'/>
      <target dev='vnet1'/>
      <alias name='net0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x09' function='0x0'/>
    </interface>
    <interface type='network'>
      <mac address='52:54:00:e5:9a:52'/>
      <source network='default'/>
      <target dev='vnet2'/>
      <alias name='net1'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/>
    </interface>
...

3. In guest, check this network interface (mac 52:54:00:e5:9a:52) can get ip and ping successfully

Comment 9 errata-xmlrpc 2011-05-19 13:27:01 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0596.html