| Summary: | fedpkg in rawhide (F16) fails to download sources | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mattias Ellert <mattias.ellert> |
| Component: | fedora-packager | Assignee: | Dennis Gilmore <dennis> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | urgent | Docs Contact: | |
| Priority: | urgent | ||
| Version: | rawhide | CC: | dcantrell, dennis, rdieter, rhbugs |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-02-11 19:49:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Mattias Ellert
2011-02-11 00:56:41 UTC
It works fine for other builds.
Perhaps the ruby guidelines need updating (or fix whatever is supposed to provide ruby_sitearch). that macro should be made safer, in case ruby isn't present (like when srpm is being generated), change to something like:
%{!?ruby_sitearch:%global ruby_sitearch %(ruby -rrbconfig -e 'puts
Config::CONFIG["sitearchdir"]' 2>/dev/null || echo "ruby_not_present")}
fedpkg does now parse the spec in order to gain information such as the package name, so if your spec parsing fails in a minimal environment that's going to be a bad thing. It was a bad thing already, now it's just explicitly bad :) I would recommend you fix up the spec so that it'll parse (rpm -q --specfile foo.spec) in a minimal environment. Did you change your minds about this? With 0.5.5.0-2.fc16 it works again: DEBUG util.py:281: Executing command: ['fedpkg', 'sources'] DEBUG util.py:247: sh: ruby: command not found DEBUG util.py:247: Downloading root-5.28.00.tar.gz DEBUG util.py:320: Child returncode was: 0 Sortof. I still say that if the spec doesn't parse and causes rpm -q to fail that fedpkg rightly fails. However I discovered in my code that if rpm spits out anything to stderr we were considering that a failure, which wasn't right. I've fixed that so that we can return clean if rpm returns clean. |