Bug 676834

Summary: [Beaker] in the Job view [Ack, Nak, comment] option missing
Product: [Retired] Beaker Reporter: Jeff Burke <jburke>
Component: web UIAssignee: Raymond Mancy <rmancy>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: 0.6CC: bpeck, dcallagh, ebaak, jstancek, mcsontos, pbunyan, rmancy
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-03-10 05:21:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jeff Burke 2011-02-11 13:26:44 UTC
Description of problem:
 Looking at a job view the Ack, Nak, comment options are not available on jobs 
submitted by other users. For example the my group review the kernel jobs from maintainers. The plan was to use Clone, Nak and comment in replace of recipes requeue. But if we can't set the Nak on other users jobs this workflow will not work.

Comment 1 Raymond Mancy 2011-02-13 22:34:57 UTC
Are you in the same group in Beaker as those who submit jobs you wish to ack/nak/comment on ?

Comment 2 Jeff Burke 2011-02-14 13:13:21 UTC
Raymond,
 Yes we are in the kernel-mtr group. But I want to make sure I didn't add some confusion. When I used the word group I am was not referring to the Beaker group. I was just saying Paul, Jan and myself need to be able to set Ack, Nak, comments on other peoples jobs. Specifically the kernel maintainers. 

 Of course if by using groups is how you would like to implement a resolution I think it may work.

 The additional thing we noticed on Friday is that individuals that have an email address that doesn't match their kerberos login name also can't set the Ack, Nak, comment on their own jobs. For example:
 email = jwilson
 kerberos = jarod

 Jarod can't Ack, Nak, comment on his own jobs.

Thanks,
Jeff

Comment 3 Raymond Mancy 2011-02-14 13:16:33 UTC
(In reply to comment #2)
> Raymond,
>  Yes we are in the kernel-mtr group. But I want to make sure I didn't add some
> confusion. When I used the word group I am was not referring to the Beaker
> group. I was just saying Paul, Jan and myself need to be able to set Ack, Nak,
> comments on other peoples jobs. Specifically the kernel maintainers. 
> 
>  Of course if by using groups is how you would like to implement a resolution I
> think it may work.
> 

I guess it would be ideal if we could have at least some level of permissions on this feature.

>  The additional thing we noticed on Friday is that individuals that have an
> email address that doesn't match their kerberos login name also can't set the
> Ack, Nak, comment on their own jobs. For example:
>  email = jwilson
>  kerberos = jarod
> 
>  Jarod can't Ack, Nak, comment on his own jobs.
> 

Oh interesting, will investigate
> Thanks,
> Jeff

Comment 4 Bill Peck 2011-03-01 22:29:22 UTC
Ray,

Can we open this up for anyone to ack/nak anyone's job?  Would it be possible to have this for the next release?  0.6.6?

Thanks

Comment 5 Raymond Mancy 2011-03-01 23:17:43 UTC
As discussed with bpeck, create group level perms on this action. Those who need to have equal access to this will need to have a group created if one does not already exist.

Comment 6 Raymond Mancy 2011-03-04 02:37:45 UTC
Jeff, I can't see how Jarod could not have access to Ack/Nak his own jobs.
I'm not really sure what's happening here. I can't find a Kerb user for 'jarod', and there is no 'jardon' in the beaker db. Only jwilson. What's his user name when he logs into beaker, and what's the user name associated with his jobs ?

Comment 7 PaulB 2011-03-04 14:07:31 UTC
Ray,
Regarding comment#5.
I believe having this ack/nak ability for members of the "kernel-mtr" group would sufffice.

Thank you.
-pbunyan

Comment 8 Raymond Mancy 2011-03-04 14:13:21 UTC
Hi Paul,
It's being implemented in such a way that any common group member of any group of which the job owner belongs to, can do the ack/nak. That should keep it generic enough.