Bug 676949

Summary: ipa cert-remove-hold "abc" trigger internal error
Product: [Retired] freeIPA Reporter: Yi Zhang <yzhang>
Component: ipa-serverAssignee: Rob Crittenden <rcritten>
Status: CLOSED ERRATA QA Contact: Chandrasekar Kannan <ckannan>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 2.0CC: benl, dpal, jgalipea, jhrozek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: freeipa-2.1.0-1.fc15 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-03-28 09:27:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Yi Zhang 2011-02-12 00:09:21 UTC 
Description of problem:
test is below:

[yi@works4me ipa-cert]$ ipa cert-remove-hold abc
ipa: ERROR: an internal error has occurred


Version-Release number of selected component (if applicable):freeipa-server-2.0-0.2011020119gitec59e61.fc14.i686


How reproducible: always


Steps to Reproduce:
1.[yi@works4me ipa-cert]$ ipa cert-remove-hold abc
ipa: ERROR: an internal error has occurred


I expect:
[yi@works4me ipa-cert]$ ipa cert-remove-hold 78
  Unrevoked: False
  Error: Record not found


http error_log:

[Fri Feb 11 16:05:25 2011] [error] ipa: DEBUG: raw: cert_remove_hold(u'abc')
[Fri Feb 11 16:05:25 2011] [error] ipa: INFO: cert_remove_hold(u'abc')
[Fri Feb 11 16:05:25 2011] [error] ipa: INFO: IPA: virtual verify certificate remove hold
[Fri Feb 11 16:05:25 2011] [error] ipa: DEBUG: ipaserver.plugins.dogtag.ra.take_certificate_off_hold()
[Fri Feb 11 16:05:25 2011] [error] ipa: ERROR: non-public: ValueError: invalid literal for int() with base 0: 'abc'
[Fri Feb 11 16:05:25 2011] [error] Traceback (most recent call last):
[Fri Feb 11 16:05:25 2011] [error]   File "/usr/lib/python2.7/site-packages/ipaserver/rpcserver.py", line 211, in wsgi_execute
[Fri Feb 11 16:05:25 2011] [error]     result = self.Command[name](*args, **options)
[Fri Feb 11 16:05:25 2011] [error]   File "/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 422, in __call__
[Fri Feb 11 16:05:25 2011] [error]     ret = self.run(*args, **options)
[Fri Feb 11 16:05:25 2011] [error]   File "/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 728, in run
[Fri Feb 11 16:05:25 2011] [error]     return self.execute(*args, **options)
[Fri Feb 11 16:05:25 2011] [error]   File "/usr/lib/python2.7/site-packages/ipalib/plugins/cert.py", line 535, in execute
[Fri Feb 11 16:05:25 2011] [error]     result=self.Backend.ra.take_certificate_off_hold(serial_number)
[Fri Feb 11 16:05:25 2011] [error]   File "/usr/lib/python2.7/site-packages/ipaserver/plugins/dogtag.py", line 1589, in take_certificate_off_hold
[Fri Feb 11 16:05:25 2011] [error]     serial_number = int(serial_number, 0)
[Fri Feb 11 16:05:25 2011] [error] ValueError: invalid literal for int() with base 0: 'abc'
[Fri Feb 11 16:05:25 2011] [error] ipa: INFO: response: InternalError: an internal error has occurred
[Fri Feb 11 16:05:25 2011] [error] ipa: INFO: Destroyed connection context.ldap2
Comment 1 Jakub Hrozek 2011-02-13 22:43:55 UTC 
The plugins should check for a valid Int literal.

https://fedorahosted.org/freeipa/ticket/958
Comment 2 Dmitri Pal 2011-02-23 20:20:18 UTC 
master: 36070555d1bd49aa1b25180db982a31dbac694a1