Bug 676979

Summary: virt-top help option and man virt-top covers incorrect default Xen hypervisor
Product: Red Hat Enterprise Linux 6 Reporter: koka xiong <kxiong>
Component: virt-topAssignee: Richard W.M. Jones <rjones>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: medium    
Version: 6.1CC: dyuan, kxiong, llim, mbooth
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: virt-top-1.0.4-3.8.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-19 14:11:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description koka xiong 2011-02-12 07:44:50 UTC
Description of problem:
Run virt-top --help and man virt-top
they both cover the default the Xen hypervisor,this is incorrect.

Version-Release number of selected component (if applicable):
virt-top-1.0.4-3.7.el6.x86_64

How reproducible:
always

Steps to Reproduce:
1.run virt-top --help
  -c uri            Connect to URI (default: Xen)
  --connect uri     Connect to URI (default: Xen)

2.man virt-top
   -c uri or --connect uri
           Connect to URI given.  The default is to connect to the Xen hypervisor.

           To connect to QEMU/KVM you would normally do -c qemu:///system

           To connect to libvirtd on a remote machine you would normally do -c xen://host/

           Full details on connection URIs is available at <http://libvirt.org/uri.html>

3.
  
Actual results:


Expected results:
In virt-top --help (default:Xen) should be omitted
In man virt-top  "The default is to connect to the Xen hypervisor." should be omitted.

Additional info:

Comment 2 Richard W.M. Jones 2011-03-08 10:44:58 UTC
Both issues are fixed upstream in
commit ad0221b4eed02049674ca4584fa4c585f0f3203f.

Upstream help output is now:

$ virt-top --help
virt-top : a 'top'-like utility for virtualization

[...]
  -c uri            Connect to libvirt URI
  --connect uri     Connect to libvirt URI
[...]

Upstream manual page now contains:

   -c uri or --connect uri
       Connect to the libvirt URI given.

       To connect to QEMU/KVM you would normally do -c qemu:///system

       To connect to Xen on the same host, do -c xen:///

       To connect to libvirtd on a remote machine you would normally do -c
       qemu://host/system

       If this option is not given then virt-top connects by default to
       whatever is the default hypervisor for libvirt, although this can
       be overridden by setting environment variables.

       See the libvirt documentation at <http://libvirt.org/uri.html> for
       further information.

Comment 3 Richard W.M. Jones 2011-03-08 10:48:18 UTC
Setting flags.

Easy fix for 6.1.

However if it is too late, then we can bump it to 6.2.

Comment 4 Richard W.M. Jones 2011-03-08 11:52:32 UTC
https://brewweb.devel.redhat.com/taskinfo?taskID=3162761

Comment 5 Richard W.M. Jones 2011-03-08 11:56:51 UTC
Flags are wrong for updating the erratum.  The error is:

----------

There were problems with the following fields:

    Idsfixed Bug 680344 does not have the correct flags. Requires rhel-6.1.0,devel_ack,qa_ack,pm_ack but only has devel_ack+, pm_ack+, qa_ack?, rhel-6.1.0?.
    Idsfixed Bug 676979 does not have the correct flags. Requires rhel-6.1.0,devel_ack,qa_ack,pm_ack but only has devel_ack+, pm_ack+, qa_ack?, rhel-6.1.0?.

Comment 8 koka xiong 2011-03-15 02:44:02 UTC
Verified with virt-top-1.0.4-3.8.el6
virt-top --help
virt-top : a 'top'-like utility for virtualization

[...]
  -c uri            Connect to libvirt URI
  --connect uri     Connect to libvirt URI
[...]

Upstream manual page now contains:

   -c uri or --connect uri
       Connect to the libvirt URI given.

       To connect to QEMU/KVM you would normally do -c qemu:///system

       To connect to Xen on the same host, do -c xen:///

       To connect to libvirtd on a remote machine you would normally do -c
       qemu://host/system

       If this option is not given then virt-top connects by default to
       whatever is the default hypervisor for libvirt, although this can
       be overridden by setting environment variables.

Comment 9 errata-xmlrpc 2011-05-19 14:11:04 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0720.html