Bug 677297

 - MUST: rpmlint must be run on every package. The output should be posted in the review.
OK - MUST: named according to the Package Naming Guidelines
OK - MUST: spec file name matches the base package %{name}
OK - MUST: package meets the Packaging Guidelines
OK - MUST: Fedora approved license and meets the Licensing Guidelines (LGPLv2+)
OK - MUST: License field in spec file matches the actual license
N/A - MUST: license file included in %doc (common for pear packages)
OK - MUST: spec is in American English
OK - MUST: spec is legible
OK - MUST: sources match the upstream source by MD5 d998750a832d6d1487c2c1acc4a7d439
OK - MUST: successfully compiles and builds into binary rpms on all arches
N/A - MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch.
OK - MUST: all build dependencies are listed in BuildRequires.
N/A - MUST: handles locales properly with %find_lang
N/A - MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.
OK - MUST: Package does not bundle copies of system libraries.
N/A - MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package.
OK - MUST: owns all directories that it creates
OK - MUST: no duplicate files in the %files listing
OK - MUST: Permissions on files are set properly, includes %defattr(...)
OK - MUST: consistently uses macros
OK - MUST: package contains code, or permissable content
N/A - MUST: Large documentation files should go in a -doc subpackage
OK - MUST: Files included as %doc do not affect the runtime of the application
N/A - MUST: Header files must be in a -devel package
N/A - MUST: Static libraries must be in a -static package
N/A - MUST: library files that end in .so are in the -devel package.
N/A - MUST: devel packages must require the base package using a fully versioned dependency
OK - MUST: The package does not contain any .la libtool archives.
N/A - MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section.
OK - MUST: package does not own files or directories already owned by other packages.
OK - Should: at the beginning of %install, the package runs rm -rf %{buildroot}.
OK - MUST: all filenames valid UTF-8


SHOULD Items:
N/A - SHOULD: Source package includes license text(s) as a separate file.
N/A - SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available.
OK - SHOULD: builds in mock.
OK - SHOULD: compiles and builds into binary rpms on all supported architectures.
OK - SHOULD: functions as described.
OK - SHOULD: Scriptlets are sane.
N/A - SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency.
N/A - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg
N/A - SHOULD: no file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
N/A - SHOULD: package should contain man pages for binaries/scripts.

Other items:
OK - latest stable version
OK - SourceURL valid
N/A - Compiler flags ok
N/A - Debuginfo complete
OK - SHOULD: package has a %clean section, which contains rm -rf %{buildroot}.
N/A - SHOULD: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'.


APPROVED!

Thanks Christoph!


New Package SCM Request
=======================
Package Name: php-pear-Net-IDNA2
Short Description: PHP library for punycode encoding and decoding
Owners: terjeros
Branches: f14 f15
InitialCC:

This ticket is not assigned to anyone; it should be assigned to the reviewer.
Please fix and re-raise the fedora-cvs flag.

Hmm, seems like Christoph did a mistake become changed QA Contact and not
Assigned To.

Christoph, is that correct?

Yes, fixed

Ok, thanks. 

Lets try again.


New Package SCM Request
=======================
Package Name: php-pear-Net-IDNA2
Short Description: PHP library for punycode encoding and decoding
Owners: terjeros
Branches: f14 f15
InitialCC:

Git done (by process-git-requests).

Thanks!

Imported, built and pushed.

Package Change Request
======================
Package Name: php-pear-Net-IDNA2
New Branches: el6
Owners: limb terjeros

Terje, I need this in EL-6 for Roundcubemail, I'll maintain, I made you a comaintainer.  If you'd rather own it, let me know and I'll orphan for you.

Thanks!

-J

Git done (by process-git-requests).