| Summary: | Updated smstools to 3.1.14 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Justin Jereza <justinjereza> | ||||||||
| Component: | smstools | Assignee: | Patrick C. F. Ernzer <pcfe> | ||||||||
| Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | el5 | CC: | mmahut, pcfe | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | i386 | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2017-04-06 10:06:08 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Attachments: |
|
||||||||||
|
Description
Justin Jereza
2011-02-14 09:57:22 UTC
Created attachment 478597 [details]
Updated and patched SRPM
Created attachment 479115 [details]
Makefile patch from Justin's smstools-3.1.14-1.src.rpm
Created attachment 479116 [details]
perm patch from Justin's smstools-3.1.14-1.src.rpm
Justin, I was not planning to update the version of smstools in EPEL5. EPEL6, F15 branch and rawhide have 3.1.14 question to you; are you fine with that package (either ability to run el6 or ability to rpmbuild (the latter I guess is a definite yes as you made your own package anyway) As to the patches, perm-patch: I got rid of that in 3.1.5-1, any reason you keep it around? Mind you, the spec file has changed quite a bit since 3.0.10 makefile-patch: is this still needed with 3.1.14-1 in EPEL6? note: while I am @redhat.com, I am not a developer, I'm just co-maintainer on this package. Patrick,
I will have to test a build of the 3.1.14 EPEL6 SRPM.
Regarding the perm-patch, I only kept it since I saw it in the EPEL5 SRPM. I was not able to test it with perm-patch removed.
As for the makefile-patch, I noticed that the CFLAGS=%{optflags} in the EPEL5 specfile overrides the CFLAGS in smstools-upstream/src/Makefile and breaks the build. I renamed CFLAGS to EXTRACFLAGS in the specfile and made the patch that inserts EXTRACFLAGS into the Makefile so that the build can proceed.
Hello again.
An update in the EL5 repo would be great, but without regression testing, I don't see how that will happen. Otherwise, I'd just build from SRPM.
After further analysis of the patches, I think the perm-patch is unnecessary if outgoing messages don't need group read/write permissions anymore.
As far as the makefile-patch is concerned, I've noticed that the most recent spec file redefines CFLAGS. Just to make it clear, the makefile-patch allows the following line:
make -C src 'CFLAGS=%{optflags} -DNOSTATS -D NUMBER_OF_MODEMS=64' %{_smp_mflags}
to become this:
make -C src 'EXTRACFLAGS=%{optflags}' %{_smp_mflags}
This allows for additional CFLAGS to be set in the spec file without disturbing whatever existing CFLAGS are set in the Makefile.
Hope this helps.
Fedora EPEL 5 changed to end-of-life (EOL) status on 2017-03-31. Fedora EPEL 5 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora or Fedora EPEL, please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |