Bug 677300

mock build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2841079
then rpmlint output on src.rpm and generated packages.

$ rpmlint -iv gtksourceviewmm3-2.91.5-1.fc16.src.rpm 
gtksourceviewmm3.src: I: checking
gtksourceviewmm3.src: W: spelling-error %description -l en_US gtksourceviewmm -> resourcefulness
The value of this tag appears to be misspelled. Please double-check.

gtksourceviewmm3.src: W: spelling-error %description -l en_US gtksourceview -> resourcefulness, resourceful, sourceless
The value of this tag appears to be misspelled. Please double-check.

gtksourceviewmm3.src: W: spelling-error %description -l en_US gtkmm 
The value of this tag appears to be misspelled. Please double-check.

gtksourceviewmm3.src: I: checking-url http://projects.gnome.org/gtksourceviewmm/ (timeout 10 seconds)
gtksourceviewmm3.src: I: checking-url http://ftp.gnome.org/pub/GNOME/sources/gtksourceviewmm/2.91/gtksourceviewmm-2.91.5.tar.bz2 (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

$ rpmlint -iv gtksourceviewmm3-2.91.5-1.fc16.x86_64.rpm 
gtksourceviewmm3.x86_64: I: checking
gtksourceviewmm3.x86_64: W: spelling-error %description -l en_US gtksourceviewmm -> resourcefulness
The value of this tag appears to be misspelled. Please double-check.

gtksourceviewmm3.x86_64: W: spelling-error %description -l en_US gtksourceview -> resourcefulness, resourceful, sourceless
The value of this tag appears to be misspelled. Please double-check.

gtksourceviewmm3.x86_64: W: spelling-error %description -l en_US gtkmm 
The value of this tag appears to be misspelled. Please double-check.

gtksourceviewmm3.x86_64: I: checking-url http://projects.gnome.org/gtksourceviewmm/ (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

$ rpmlint -iv gtksourceviewmm3-2.91.5-1.fc16.x86_64.rpm 
gtksourceviewmm3.x86_64: I: checking
gtksourceviewmm3.x86_64: W: spelling-error %description -l en_US gtksourceviewmm -> resourcefulness
The value of this tag appears to be misspelled. Please double-check.

gtksourceviewmm3.x86_64: W: spelling-error %description -l en_US gtksourceview -> resourcefulness, resourceful, sourceless
The value of this tag appears to be misspelled. Please double-check.

gtksourceviewmm3.x86_64: W: spelling-error %description -l en_US gtkmm 
The value of this tag appears to be misspelled. Please double-check.

gtksourceviewmm3.x86_64: I: checking-url http://projects.gnome.org/gtksourceviewmm/ (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

[x] package passes
[-] not applicable
[!] package fails

== MUST ==

[x] rpmlint output
[x] The package must be named according to the Package Naming Guidelines
[x] The spec file name must match the base package %{name}
[x] The package must meet the Packaging Guidelines
[x] The package must be licensed with a Fedora approved license
[x] The License field in the package spec file must match the actual license.
[x] If (and only if) the source package includes the text of the license(s) in its own file, then that file must be included in %doc
[x] The spec file must be written in American English
[x] The spec file for the package MUST be legible
[x] The sources used to build the package must match the upstream source, as provided in the spec URL
    $ sha1sum gtksourceviewmm-2.91.5.tar.bz2 
    54a83ddd5cd946f73180d51138f7a1781c655bb1  gtksourceviewmm-2.91.5.tar.bz2
[x] The package '''MUST''' successfully compile and build into binary rpms on at least one primary architecture
[-] The spec file MUST handle locales properly
[x] Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun
[x] Packages must NOT bundle copies of system libraries
[-] If the package is designed to be relocatable, the packager must state this fact in the request for review
[x] A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.
[x] A Fedora package must not list a file more than once in the spec file's %files listings
[x] Permissions on files must be set properly
[x] Each package must consistently use macros
[x] The package must contain code, or permissable content
[x] Large documentation files must go in a -doc subpackage
    $ rpm2cpio gtksourceviewmm3-devel-2.91.5-1.fc16.x86_64.rpm | cpio -id
    5957 blocks
    $ du -sh usr/share/gtk-doc
    2.9M	usr/share/gtk-doc

[x] If a package includes something as %doc, it must not affect the runtime of the application
[x] Header files must be in a -devel package
[-] Static libraries must be in a -static package
[x] If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package
[!] Subpackages requiring the base package
[x] Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built
[-] Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section
[x] Packages must not own files or directories already owned by other packages
[x] All filenames in rpm packages must be valid UTF-8

== SHOULD ==

[-] If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it
[-] If scriptlets are used, those scriptlets must be sane
[-] Usually, subpackages other than devel should require the base package using a fully versioned dependency
[x] The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg
[-] If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself
[-] your package should contain man pages for binaries/scripts

== To fix ==

The -devel subpackage requires the base one without specifying the architecture. From the packaging guidelines:
"""
When a subpackage requires the base package, it must do so using a fully versioned arch-specific (for non-noarch packages) dependency:
    Requires: %{name}%{?_isa} = %{version}-%{release}
"""

== Notes ==

The -devel subpackage includes this file:
    %{_includedir}/*

It doesn't seem necessary since all files installed in /usr/include are already covered by this line:
    %{_includedir}/%{tarname}-%{apiver}

Thank you Mathieu for your review.
I already fixed the architecture requirements issue, for the headers, they are versionned as you might have different versions of the gtkmm stack installed in parallel (Fedora actually ships gtkmm24/gtkmm30).
The spec and src.rpm above were updated and i submitted a scratch build.
http://koji.fedoraproject.org/koji/taskinfo?taskID=2848773

Ok, just remove the redondant %{_includedir}/* when importing the package then.

Package is approved.

One shall not be hammered when packaging, i'll remove that useless bit before building. 

New Package SCM Request
=======================
Package Name: gtksourceviewmm3
Short Description: A C++ wrapper for gtksourceview3
Owners: hguemar
Branches: f15
InitialCC: hguemar

The requested package name and the package name in the ticket summary do not
match.  Please fix whichever is incorrect and re-raise the fedora-cvs flag.

fixed the typo in summary.

New Package SCM Request
=======================
Package Name: gtksourceviewmm3
Short Description: A C++ wrapper for gtksourceview3
Owners: hguemar
Branches: f15
InitialCC: hguemar

Git done (by process-git-requests).