Bug 677410

Summary:	Download sig check now holds the rpmdb ts lock, for all of downloads
Product:	Red Hat Enterprise Linux 6	Reporter:	James Antill <james.antill>
Component:	yum	Assignee:	James Antill <james.antill>
Status:	CLOSED ERRATA	QA Contact:	Karel Srot <ksrot>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.1	CC:	ebenes, ksrot, tcapek
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	yum-3.2.29-6.el6	Doc Type:	Bug Fix
Doc Text:	Certain commits caused yum to hold the RPM database open throughout the remaining package download, after the first signature check happened. As a consequence, when a user pressed Ctrl+C, the shortcut could not be properly recognized and reacted upon. With this update, this bug has been fixed and no longer occurs.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-05-19 13:34:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description James Antill 2011-02-14 17:11:19 UTC

Description of problem:

See:

http://lists.baseurl.org/pipermail/yum-devel/2011-February/007898.html

...we now hold a ts across downloads, simple fix for 6.1 is to just undo that commit ... it's much less useful on RHEL-6 than Fedora. But importing the upstream fix is also viable.

 I've marked this as a regression, but truthfully I have no idea how well C-c works without this bug ... so it might not really be a regression from RHEL-6.0, so could wait until 6.2 etc.

Comment 2 Karel Srot 2011-03-28 08:36:47 UTC

James, 
I can see the patch is applied in yum-3.2.29-4.el6 but I can't see any strange behavior after Ctrl-C during pkg download. Did I miss something?

Comment 3 James Antill 2011-03-28 16:06:53 UTC

 You mean you can't see any weird behaviour with C-c before -4 ? That's pretty special, but then that's rpm for you :)
 Did you check with a normal repo. or an RHN repo?

 Given the fix in BZ-677410-Download-sig-check-holds-the-rpmdb-ts-lock.patch ... it's pretty risk free, and anything with that patch should behave as the 6.0 yum does. But confirmation that it breaks, and is fixed is always nice :).

Comment 4 Karel Srot 2011-03-29 06:31:37 UTC

Well, in yum..-4 I can see the commit applied. As I understand, This commit is causing holding rpmdb open during the download and thus Ctrl-C during the download may result in "some" issue... And bz677410 is removing that commit.
Therefore I was checking it on -4 to see what is that issue so I can verify it does not occur in later versions.

I was using normal repo. After "yum update" I have pressed Ctrl-C during the download of the second package (is that right?). But as I said, didn't saw anything strange. Maybe my test scenario is not correct.

Comment 7 Tomas Capek 2011-05-17 12:00:29 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Certain commits caused yum to hold the RPM database open throughout the remaining package download, after the first signature check happened. As a consequence, when a user      pressed Ctrl+C, the shortcut could not be properly recognized and reacted upon. With this update, this bug has been fixed and no longer occurs.

Comment 8 errata-xmlrpc 2011-05-19 13:34:08 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0602.html