Bug 677676
| Summary: | Don't autostart print-applet in gnome for f15 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthias Clasen <mclasen> |
| Component: | system-config-printer | Assignee: | Tim Waugh <twaugh> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jpopelka, mkasik, twaugh |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | system-config-printer-1.3.1-1.fc15 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-03-03 02:54:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Matthias Clasen
2011-02-15 14:48:37 UTC
Matthias, will this break automatic print driver installation, or does GNOME 3 already handle this? https://fedoraproject.org/wiki/Features/AutomaticPrintDriverInstallation Note that system-config-printer-applet also provides the interface that displays notifications about printers being connected, i.e. this stuff: http://cyberelk.net/tim/2007/05/24/new-printer-notification-mock-ups/ Can GNOME 3 do that now? The code looks like it gives you the notification, at least. http://git.gnome.org/browse/gnome-settings-daemon/tree/plugins/print-notifications/gsd-print-notifications-manager.c CCing mkasik to get information about printer driver installation Oh. :-( Thanks for the link to the code. I have comments: It's using a really old method of doing that stuff (com.redhat.PrinterSpooler, which should only be used for QueueChanged, not anything else), and looks to be *incredibly* inefficient: num_jobs = cupsGetJobs (&jobs, printer_name, 1, CUPS_WHICHJOBS_ALL); (that might take a minute or more, blocking not only gnome-settings-daemon but also cupsd for all that time -- every time it is run.) Also it looks like it's showing notifications every time *any* print job changes, not just "mine"? Not only that, but is it showing "Printer added" notifications every time a new printer is advertised on the network? The way it ought to be done is using IPP subscriptions. This is much more efficient. Timeliness can be improved by using D-Bus, but a different interface should be used by preference: org.cups.cupsd.Notifier. Additionally, only "my" jobs should trigger desktop notifications. Otherwise I'll have notifications whenever anyone prints documents. It looks like there is no notification of printer issues i.e. printer-state-reasons. Hopefully that's planned? No, there's no support there yet for automatic print driver installation AFAICS. I'd like to help if I can... Sure, any hints you have will be gladly received. I hope Marek is listening here now. Hi Tim, thank you for your comments. I'm going to fix it right now. Marek I've just built system-config-printer-1.3.0-2.fc15. It still runs the applet, but only gets it to start the NewPrinterNotification and PrinterDriversInstaller D-Bus services. Job notifications are not done. Once gnome-settings-daemon handles the New Printer notifications (com.redhat.NewPrinterNotification) and PrinterDriversInstaller requests (com.redhat.PrinterDriversInstaller), we can kill the applet completely. system-config-printer-1.3.0-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/system-config-printer-1.3.0-2.fc15 system-config-printer-1.3.0-2.fc15 has been pushed to the Fedora 15 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update system-config-printer'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/system-config-printer-1.3.0-2.fc15 system-config-printer-1.3.1-1.fc15 has been pushed to the Fedora 15 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update system-config-printer'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/system-config-printer-1.3.1-1.fc15 system-config-printer-1.3.1-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. |