Bug 677712

Summary: disabling vmware device emulation breaks old->new migration
Product: Red Hat Enterprise Linux 6 Reporter: Paolo Bonzini <pbonzini>
Component: qemu-kvmAssignee: Eduardo Habkost <ehabkost>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: low    
Version: 6.0CC: amit.shah, chayang, ddumas, ehabkost, fyang, juzhang, llim, michen, mjenner, mkenneth, rlerch, tburke, virt-maint
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: qemu-kvm-0.12.1.2-2.146.el6 Doc Type: Bug Fix
Doc Text:
[not a regression from 6.0.0, but a fix for a issue introduced during 6.1 development]
Story Points: ---
Clone Of: 616187 Environment:
Last Closed: 2011-05-19 11:32:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 580951, 616187    

Description Paolo Bonzini 2011-02-15 16:18:46 UTC
+++ This bug was initially created as a clone of Bug #616187 +++

Description of problem:
On RHEL5 we used the --disable-vmware option to disable th VMWare device emulation on qemu-kvm. On RHEL6 this feature is enabled at build time (as the patch to make it optional was not included upstream), but it is not a supported feature.


Version-Release number of selected component (if applicable):
qemu-kvm-0.12.1.2-2.96.el6

--- Additional comment from pm-rhel on 2010-07-19 15:58:07 EDT ---

This issue has been proposed when we are only considering blocker
issues in the current Red Hat Enterprise Linux release.

** If you would still like this issue considered for the current
release, ask your support representative to file as a blocker on
your behalf. Otherwise ask that it be considered for the next
Red Hat Enterprise Linux release. **

--- Additional comment from bburns on 2010-07-20 08:31:53 EDT ---

Moved BZ to 6.1, release note is needed for 6.0.

--- Additional comment from rlerch on 2010-08-30 19:19:39 EDT ---

This bug appears to be a known issue that is to be documented in the Technical Notes for the RHEL 6.0 Release.

Please provide information covering the following 4 dot points in the technical notes field above:

* Cause
    What actions or circumstances cause the bug to present (if known).
    Note: if the cause is not known or is not fully diagnosed,
    current hypotheses or theories should be noted.
* Consequence
    What happens when the bug presents.
* Workaround
    What actions, if any, reduce the bug’s effects or prevent it from presenting 
    entirely.
* Result
    If the bug’s effect is only reduced, what consequences still flow;
    if the bug is prevented, what restrictions does the workaround impose.

--- Additional comment from ddumas on 2010-09-10 16:04:50 EDT ---


    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
"Although there are qemu-kvm options to enable VMWare device emulation,
this feature is neither supported nor functional."

--- Additional comment from rlerch on 2010-10-18 23:23:06 EDT ---

Added this Known Issue to the 6.0 GA Technical Notes.

http://documentation-stage.bne.redhat.com/docs/en-US/Red_Hat_Enterprise_Linux/6/html/Technical_Notes/virt.html

If this note is incorrect, or needs to be changed, please edit the Technical Notes field above, and set the technical_notes flag to '?'	

cheers,
ryanlerch

--- Additional comment from rlerch on 2010-10-18 23:23:06 EDT ---


    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,2 +1 @@
-"Although there are qemu-kvm options to enable VMWare device emulation,
+The qemu-kvm options to enable VMware device emulation are not functional or supported in Red Hat Enterprise Linux 6.-this feature is neither supported nor functional."

--- Additional comment from sneuner on 2010-11-10 17:57:32 EST ---

Given this has been released noted as not supported (and it wasn't ever really supported), I don't see this as that critical.  The current priority of low seems reasonable for now.  

However, it should be pretty straightforward by either adding the disable flag back in or just disabling it altogether for 6.1.  Thus, I'm setting this BZ to 'KVMtier3' for now with a dev_ack+ assuming its easy to address for 6.1.  If that's not the case, please let me know and provide more info within this BZ.  Thanks, steve

--- Additional comment from chayang on 2011-01-18 00:21:11 EST ---

(In reply to comment #0)
> Description of problem:
> On RHEL5 we used the --disable-vmware option to disable th VMWare device
> emulation on qemu-kvm. On RHEL6 this feature is enabled at build time (as the
> patch to make it optional was not included upstream), but it is not a supported
> feature.
> 
> 
> Version-Release number of selected component (if applicable):
> qemu-kvm-0.12.1.2-2.96.el6

Hi Eduardo,
According to your description of problem, I checked and booted a guest on rhel6, it seems that vmware device works fine. Here is the cli, if any mistake, please correct me.

# /usr/libexec/qemu-kvm --help|grep vmware
-vga [std|cirrus|vmware|xenfb|qxl|none]

# /usr/libexec/qemu-kvm -M rhel6.0.0 -enable-kvm -m 2048 -smp 2 -uuid 3aea0aa3-0920-9b9c-0d01-ecb38f241678 -nodefconfig -nodefaults -rtc base=utc -boot c -drive file=/var/lib/libvirt/images/rhel5.img,if=none,id=drive-ide0-0-0,format=raw,cache=none -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 -netdev tap,id=hostnet0 -device rtl8139,netdev=hostnet0,id=net0,mac=52:54:00:20:a9:6c,bus=pci.0,addr=0x3 -usb -device usb-tablet -vnc 127.0.0.1:0 -vga vmware -monitor stdio

In guest:
# cat /etc/X11/xorg.conf
# Xorg configuration created by system-config-display

Section "ServerLayout"
	Identifier     "single head configuration"
	Screen      0  "Screen0" 0 0
	InputDevice    "Keyboard0" "CoreKeyboard"
EndSection

Section "InputDevice"
	Identifier  "Keyboard0"
	Driver      "kbd"
	Option	    "XkbModel" "pc105"
	Option	    "XkbLayout" "us"
EndSection

Section "Device"
	Identifier  "Videocard0"
	Driver      "vmware"
EndSection

Section "Screen"
	Identifier "Screen0"
	Device     "Videocard0"
	DefaultDepth     24
	SubSection "Display"
		Viewport   0 0
		Depth     24
	EndSubSection
EndSection


# rpm -qa|grep qemu-kvm
qemu-kvm-debuginfo-0.12.1.2-2.128.el6.x86_64
qemu-kvm-tools-0.12.1.2-2.128.el6.x86_64
qemu-kvm-0.12.1.2-2.128.el6.x86_64

--- Additional comment from chayang on 2011-01-18 00:22:36 EST ---

Created attachment 473971 [details]
vmware device works correctly

--- Additional comment from ehabkost on 2011-01-31 15:03:15 EST ---

The code to disable the vmware devices is not present upstream, so we need to include it upstream first, before adding --disable-vmware to our code. Setting Conditional NAK: Upstream.

--- Additional comment from pm-rhel on 2011-01-31 15:21:08 EST ---

This bug report previously had all acks and release flags approved.
However since at least one of its acks has been changed, the
release flags have been reset to ? by the bugbot (pm-rhel).  The
ack needs to become approved before the release flags can become
approved again.

--- Additional comment from ehabkost on 2011-02-03 10:51:22 EST ---

Patch(es) posted for review and queued. Changing status to POST
http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-February/msg00243.html
http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-February/msg00246.html
http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-February/msg00245.html
http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-February/msg00247.html
http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-February/msg00248.html

--- Additional comment from lcapitulino on 2011-02-15 07:03:26 EST ---


Patches acked:
* Patch: Add config-devices.h again
  (Message-Id: <1297709699-2894-2-git-send-email-ehabkost>)
  - Acked-by: Juan Quintela <quintela>
  - Acked-by: john cooper <john.cooper>
  - Acked-by: Alex Williamson <alex.williamson>

* Patch: Add CONFIG_VMWARE_VGA (v2)
  (Message-Id: <1297709699-2894-3-git-send-email-ehabkost>)
  - Acked-by: Juan Quintela <quintela>
  - Acked-by: john cooper <john.cooper>
  - Acked-by: Alex Williamson <alex.williamson>

* Patch: add CONFIG_VMMOUSE option (v2)
  (Message-Id: <1297709699-2894-4-git-send-email-ehabkost>)
  - Acked-by: Juan Quintela <quintela>
  - Acked-by: john cooper <john.cooper>
  - Acked-by: Alex Williamson <alex.williamson>

* Patch: add CONFIG_VMPORT option (v2)
  (Message-Id: <1297709699-2894-5-git-send-email-ehabkost>)
  - Acked-by: Juan Quintela <quintela>
  - Acked-by: john cooper <john.cooper>
  - Acked-by: Alex Williamson <alex.williamson>

* Patch: spec file: disable vmware devices on config-devices.mak
  (Message-Id: <1297709699-2894-6-git-send-email-ehabkost>)
  - Acked-by: Juan Quintela <quintela>
  - Acked-by: john cooper <john.cooper>
  - Acked-by: Alex Williamson <alex.williamson>

--- Additional comment from lcapitulino on 2011-02-15 07:58:46 EST ---

Patch(es) included on qemu-kvm-0.12.1.2-2.145.el6

=================================================

The above patches cause migration from old to new qemu-kvm to fail with

Unknown savevm section or instance 'vmmouse' 0
load of migration failed

Comment 5 YangFeng 2011-03-04 05:29:53 UTC
Patches have been applied and work well.
So this bug have been verified.

Comment 6 Eduardo Habkost 2011-05-05 17:38:37 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
[not a regression from 6.0.0, but a fix for a issue introduced during 6.1 development]

Comment 9 errata-xmlrpc 2011-05-19 11:32:43 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0534.html

Comment 10 errata-xmlrpc 2011-05-19 13:01:39 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0534.html