Bug 677752

Summary: FEAT: network test ICMP/ping test improvements
Product: [Retired] Red Hat Hardware Certification Program Reporter: Greg Nichols <gnichols>
Component: Test Suite (tests)Assignee: Greg Nichols <gnichols>
Status: CLOSED ERRATA QA Contact: Guangze Bai <gbai>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 1.2CC: czhang, gbai, rlandry, ykun, yshao, yuchen
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
A new enhancement has been made in v7 1.3 that network test ICMP/ping test is improved to produce less verbose output in flood-ping mode and 5 re-tries on fail is allowed.
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-09 16:11:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
network test patch with -q on ping for quieter output
none
network test patch changing icmp test to try 5 times max at 5000 count none

Description Greg Nichols 2011-02-15 18:24:38 UTC
Description of problem:

The network test uses ping -f, producing period characters and back-spaces to indicate progress, but this has no value in test logs.   The network test should run ping with less-verbose options.

Comment 1 Greg Nichols 2011-02-17 15:43:16 UTC
I suggest we change the use of ping to use the -q option.   This changes the logged output to be:


PING gnichols.usersys.redhat.com (10.16.47.158) 56(84) bytes of data.

--- gnichols.usersys.redhat.com ping statistics ---
1000 packets transmitted, 1000 received, 0% packet loss, time 250ms
rtt min/avg/max/mdev = 0.217/0.230/0.429/0.012 ms, ipg/ewma 0.250/0.230 ms
PING gnichols.usersys.redhat.com (10.16.47.158) 1(29) bytes of data.


repeated for each size option.

Comment 2 Rob Landry 2011-02-17 15:57:19 UTC
We should do some packet drop runs as well to see how visible that is.  If the -f option makes them more clear we may want to keep it, otherwise though, works for me.

Comment 3 Greg Nichols 2011-02-17 19:32:19 UTC
Created attachment 479385 [details]
network test patch with -q on ping for quieter output

This patch also adds warnings for packet loss.   Note the array constant on line 341, which allows a warning threshold to be set for each packet size.

Comment 4 Greg Nichols 2011-02-17 19:35:44 UTC
Example output with above patch (note: margin lowered to 10% to show warning).

[...]
--- gnichols.usersys.redhat.com ping statistics ---
1000 packets transmitted, 1000 received, 0% packet loss, time 2249ms
rtt min/avg/max/mdev = 2.141/2.195/2.479/0.036 ms, ipg/ewma 2.252/2.194 ms
/bin/ping -i 0 -q -c 1000 -s 40000 gnichols.usersys.redhat.com
PING gnichols.usersys.redhat.com (10.16.47.158) 40000(40028) bytes of data.

--- gnichols.usersys.redhat.com ping statistics ---
1000 packets transmitted, 165 received, 83% packet loss, time 10872ms
rtt min/avg/max/mdev = 7.300/7.353/7.549/0.085 ms, ipg/ewma 10.882/7.345 ms
Warning: packet loss of 83% is greater than 10% expected

/bin/ping -i 0 -q -c 1000 -s 65507 gnichols.usersys.redhat.com
PING gnichols.usersys.redhat.com (10.16.47.158) 65507(65535) bytes of data.
--- gnichols.usersys.redhat.com ping statistics 
---1000 packets transmitted, 0 received, 100% packet loss, time 21465ms
Error:
"/bin/ping -i 0 -q -c 1000 -s 65507 gnichols.usersys.redhat.com" returned 1
FAIL

Comment 5 Greg Nichols 2011-02-17 19:36:31 UTC
Question: what are "good" margin settings for each packet size?

Comment 9 Greg Nichols 2011-03-30 15:33:54 UTC
Created attachment 488804 [details]
network test patch changing icmp test to try 5 times max at 5000 count

Comment 14 Caspar Zhang 2011-05-01 09:43:15 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
A new enhancement has been made in v7 1.3 that network test ICMP/ping test is improved to produce less verbose output in flood-ping mode and 5 re-tries on fail is allowed.

Comment 15 errata-xmlrpc 2011-05-09 16:11:33 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0497.html