Bug 678612

Summary: service qpidd stop [failed] - with --log-to-stdout yes
Product: Red Hat Enterprise MRG Reporter: ppecka <ppecka>
Component: qpid-cppAssignee: Alan Conway <aconway>
Status: CLOSED ERRATA QA Contact: Leonid Zhaldybin <lzhaldyb>
Severity: medium Docs Contact:
Priority: medium    
Version: 1.3CC: esammons, gsim, iboverma, jross, lzhaldyb, mcressma, pematous
Target Milestone: 2.3   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 0.12 Doc Type: Bug Fix
Doc Text:
Cause: Some qpidd log messages were output before the PID when running qpidd --check Consequence: With log-to-stdout=yes, qpidd --quit does not work. Fix: Removed log messages, unnecessary. Result: qpidd --quit works as expected.
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-03-06 18:53:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description ppecka 2011-02-18 15:37:52 UTC
Description of problem:
having log-to-stdout=yes in /etc/qpidd.conf has impact on service qpidd stop command. After service qpidd stop, service is still up, even on multiple retries

Version-Release number of selected component (if applicable):
# rpm -qa |grep qpid | sort -u
python-qpid-0.7.946106-15.el5
qpid-cpp-client-0.7.946106-28.el5
qpid-cpp-client-devel-0.7.946106-28.el5
qpid-cpp-client-devel-docs-0.7.946106-28.el5
qpid-cpp-client-ssl-0.7.946106-28.el5
qpid-cpp-server-0.7.946106-28.el5
qpid-cpp-server-cluster-0.7.946106-28.el5
qpid-cpp-server-devel-0.7.946106-28.el5
qpid-cpp-server-ssl-0.7.946106-28.el5
qpid-cpp-server-store-0.7.946106-28.el5
qpid-cpp-server-xml-0.7.946106-28.el5
qpid-java-client-0.7.946106-15.el5
qpid-java-common-0.7.946106-15.el5
qpid-java-example-0.7.946106-15.el5
qpid-tests-0.7.946106-1.el5
qpid-tools-0.7.946106-12.el5


How reproducible:
100%

Steps to Reproduce:
1.change /etc/qpidd.conf
cluster-mechanism=ANONYMOUS
auth=no
log-enable=trace+
log-to-stdout=yes
log-to-stderr=no

2. service  qpidd start
3. service qpidd stop
    ^^^ fails here ^^^


Actual results:
service qpidd restart
Stopping Qpid AMQP daemon:                                 [  OK  ]
Starting Qpid AMQP daemon: 2011-02-17 13:14:29 info Loaded Module: /usr/lib/qpid/daemon/msgstore.so
2011-02-17 13:14:29 info Loaded Module: /usr/lib/qpid/daemon/ssl.so
2011-02-17 13:14:29 info Loaded Module: /usr/lib/qpid/daemon/replicating_listener.so
2011-02-17 13:14:29 info Loaded Module: /usr/lib/qpid/daemon/xml.so
2011-02-17 13:14:29 info Loaded Module: /usr/lib/qpid/daemon/watchdog.so
2011-02-17 13:14:29 info Loaded Module: /usr/lib/qpid/daemon/replication_exchange.so
2011-02-17 13:14:29 info Loaded Module: /usr/lib/qpid/daemon/acl.so
2011-02-17 13:14:29 info Loaded Module: /usr/lib/qpid/daemon/cluster.so
2011-02-17 13:14:29 debug Forked daemon child process
                                                           [  OK  ]
[root@dev-02 ~]# service qpidd restart
Stopping Qpid AMQP daemon:                                 [FAILED]
Starting Qpid AMQP daemon: 2011-02-17 13:14:31 info Loaded Module: /usr/lib/qpid/daemon/msgstore.so
2011-02-17 13:14:31 info Loaded Module: /usr/lib/qpid/daemon/ssl.so
2011-02-17 13:14:31 info Loaded Module: /usr/lib/qpid/daemon/replicating_listener.so
2011-02-17 13:14:31 info Loaded Module: /usr/lib/qpid/daemon/xml.so
2011-02-17 13:14:31 info Loaded Module: /usr/lib/qpid/daemon/watchdog.so
2011-02-17 13:14:31 info Loaded Module: /usr/lib/qpid/daemon/replication_exchange.so
2011-02-17 13:14:31 info Loaded Module: /usr/lib/qpid/daemon/acl.so
2011-02-17 13:14:31 info Loaded Module: /usr/lib/qpid/daemon/cluster.so
2011-02-17 13:14:31 debug Forked daemon child process
2011-02-17 13:14:31 debug Exception constructed: Daemon startup failed: Cannot lock /var/lib/qpidd/lock: Resource temporarily unavailable
Daemon startup failed: Cannot lock /var/lib/qpidd/lock: Resource temporarily unavailable
2011-02-17 13:14:31 critical Unexpected error: Daemon startup failed: Cannot lock /var/lib/qpidd/lock: Resource temporarily unavailable
                                                           [FAILED]

Expected results:
service qpidd stop results in stopping qpidd servicing clients.

Additional info:

Comment 1 Alan Conway 2011-03-14 15:05:35 UTC
Changed severity to medium. There is no reason to use log-to-stdout if you are using the service start/stop scripts since the output to stdout will be lost anyway. log-to-stdout is intended more for debugging/development situations.

The problem is that qpidd --check which is used to get the PID of the daemon writes the PID to stdout. With log-to-stdout, the log messages obscure the PID. Requires some reorganization of qpidd's start-up code to correct.

Comment 2 Alan Conway 2011-03-14 20:31:41 UTC
Fixed in r1081548

See https://issues.apache.org/jira/browse/QPID-3144

Comment 4 Leonid Zhaldybin 2012-10-10 10:44:32 UTC
Tested on RHEL5.8 and RHEL6.3 (both i386 and x86_64). The issue has been fixed.

Packages used for testing:

RHEL5.8
qpid-cpp-client-0.18-1.el5
qpid-cpp-client-devel-0.18-1.el5
qpid-cpp-client-devel-docs-0.18-1.el5
qpid-cpp-client-rdma-0.18-1.el5
qpid-cpp-client-ssl-0.18-1.el5
qpid-cpp-mrg-debuginfo-0.18-1.el5
qpid-cpp-server-0.18-1.el5
qpid-cpp-server-cluster-0.18-1.el5
qpid-cpp-server-devel-0.18-1.el5
qpid-cpp-server-rdma-0.18-1.el5
qpid-cpp-server-ssl-0.18-1.el5
qpid-cpp-server-store-0.18-1.el5
qpid-cpp-server-xml-0.18-1.el5

RHEL6.3
qpid-cpp-client-0.18-1.el6_3
qpid-cpp-client-devel-0.18-1.el6_3
qpid-cpp-client-devel-docs-0.18-1.el6_3
qpid-cpp-client-rdma-0.18-1.el6_3
qpid-cpp-client-ssl-0.18-1.el6_3
qpid-cpp-debuginfo-0.18-1.el6_3
qpid-cpp-server-0.18-1.el6_3
qpid-cpp-server-cluster-0.18-1.el6_3
qpid-cpp-server-devel-0.18-1.el6_3
qpid-cpp-server-rdma-0.18-1.el6_3
qpid-cpp-server-ssl-0.18-1.el6_3
qpid-cpp-server-store-0.18-1.el6_3
qpid-cpp-server-xml-0.18-1.el6_3

-> VERIFIED

Comment 6 errata-xmlrpc 2013-03-06 18:53:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0561.html