Bug 678674
| Summary: | Review Request: rubygem-goocanvas - Ruby binding of GooCanvas | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mamoru TASAKA <mtasaka> |
| Component: | Package Review | Assignee: | Darryl L. Pierce <dpierce> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dpierce, fedora-package-review, notting, tross |
| Target Milestone: | --- | Flags: | dpierce:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-12-23 17:15:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Mamoru TASAKA
2011-02-18 20:44:35 UTC
http://mtasaka.fedorapeople.org/Review_request/rubygem-goocanvas/rubygem-goocanvas-0.90.8-1.fc.src.rpm http://mtasaka.fedorapeople.org/Review_request/rubygem-goocanvas/rubygem-goocanvas.spec * Thu Mar 10 2011 Mamoru Tasaka <mtasaka> - 0.90.8-1 - 0.90.8 http://mtasaka.fedorapeople.org/Review_request/rubygem-goocanvas/rubygem-goocanvas.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-goocanvas/rubygem-goocanvas-0.90.8-2.fc.src.rpm * Sun Apr 10 2011 Mamoru Tasaka <mtasaka> - 0.90.8-2 - Some cleanups http://mtasaka.fedorapeople.org/Review_request/rubygem-goocanvas/rubygem-goocanvas.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-goocanvas/rubygem-goocanvas-1.0.0-1.fc.src.rpm * Sun Jul 17 2011 Mamoru Tasaka <mtasaka> - 1.0.0-1 - 1.0.0 - Kill non-gem support on F-16+ http://mtasaka.fedorapeople.org/Review_request/rubygem-goocanvas/rubygem-goocanvas-1.0.3-1.fc.src.rpm http://mtasaka.fedorapeople.org/Review_request/rubygem-goocanvas/rubygem-goocanvas.spec * Thu Dec 22 2011 Mamoru Tasaka <mtasaka> - 1.0.3-1 - 1.0.3 All looks good, with the following notes:
* MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.[1]
OUTPUT:
mcpierce@mcpierce-laptop:review $ rpmlint rubygem-goocanvas-1.0.3-1.fc.src.rpm
rubygem-goocanvas.src: E: changelog-time-in-future 2011-12-22
rubygem-goocanvas.src:24: W: mixed-use-of-spaces-and-tabs (spaces: line 24, tab: line 1)
1 packages and 0 specfiles checked; 1 errors, 1 warnings.
The changelog in the future may just be a timezone issue.
* The package must have a Requires and a BuildRequires on rubygems
I see no such elements in the specfile.
All else looks good. With the Requires/BuildRequires changes made, I approve this package.
Thank you for review! (In reply to comment #5) > * The package must have a Requires and a BuildRequires on rubygems > I see no such elements in the specfile. Since other rubygem-foo-devel or rubygem(bar) has the dependency for rubygems, I think this isredundant, however if you think it is preferred I will add when importing this into Fedora git. New Package SCM Request ======================= Package Name: rubygem-goocanvas Short Description: Ruby binding of GooCanvas Owners: mtasaka Branches: f16 f15 InitialCC: Git done (by process-git-requests). Imported. Thank you for review and git procedure. Closing. |